test: Use cmp to compare dict result instead of json.dumps

Author: abawchen

graphene_mongo/tests/test_query.py

@@ -42,7 +42,7 @@ def resolve_editors(self, *args, **kwargs):
     expected = {
         'editor': {
             'firstName': 'Penny',
-            'company': {"name": "Newsco"}
+            'company': {'name': 'Newsco'}
         },
         'editors': [{
             'firstName': 'Penny',
@@ -55,15 +55,17 @@ def resolve_editors(self, *args, **kwargs):
             'lastName': 'Rodman'
         }]
     }
-    expected_metadata = '{"age": "20", "nickname": "$1"}'
+    expected_metadata = {
+        'age': '20',
+        'nickname': "$1"
+    }
 
     schema = graphene.Schema(query=Query)
     result = schema.execute(query)
     assert not result.errors
     metadata = result.data['editor'].pop('metadata')
-    assert (json.loads(metadata)) == dict(json.loads(expected_metadata))
-    assert json.dumps(result.data, sort_keys=True) == \
-        json.dumps(expected, sort_keys=True)
+    assert cmp(json.loads(metadata), expected_metadata) == 0
+    assert cmp(result.data, expected) == 0
 
 
 def test_should_query_reporter(fixtures):
@@ -125,7 +127,7 @@ def resolve_reporter(self, *args, **kwargs):
     schema = graphene.Schema(query=Query)
     result = schema.execute(query)
     assert not result.errors
-    assert dict(result.data['reporter']) == expected['reporter']
+    assert cmp(result.data, expected) == 0
 
 
 def test_should_custom_kwargs(fixtures):
@@ -163,7 +165,7 @@ def resolve_editors(self, *args, **kwargs):
     schema = graphene.Schema(query=Query)
     result = schema.execute(query)
     assert not result.errors
-    assert all(item in result.data['editors'] for item in expected['editors'])
+    assert cmp(result.data, expected) == 0
 
 
 def test_should_self_reference(fixtures):
@@ -232,8 +234,7 @@ def resolve_all_players(self, *args, **kwargs):
     schema = graphene.Schema(query=Query)
     result = schema.execute(query)
     assert not result.errors
-    assert json.dumps(result.data, sort_keys=True) == \
-        json.dumps(expected, sort_keys=True)
+    assert cmp(result.data, expected) == 0
 
 
 def test_should_query_with_embedded_document(fixtures):
@@ -266,8 +267,7 @@ def resolve_professor_vector(self, info, id):
     schema = graphene.Schema(query=Query, types=[ProfessorVectorType])
     result = schema.execute(query)
     assert not result.errors
-    assert json.dumps(result.data, sort_keys=True) == \
-        json.dumps(expected, sort_keys=True)
+    assert cmp(result.data, expected) == 0
 
 
 def test_should_query_child(fixtures):
@@ -311,8 +311,7 @@ def resolve_children(self, *args, **kwargs):
     schema = graphene.Schema(query=Query)
     result = schema.execute(query)
     assert not result.errors
-    assert json.dumps(result.data, sort_keys=True) == \
-        json.dumps(expected, sort_keys=True)
+    assert cmp(result.data, expected) == 0
 
 
 def test_should_query_cell_tower(fixtures):
@@ -372,5 +371,4 @@ def resolve_cell_towers(self, *args, **kwargs):
     schema = graphene.Schema(query=Query)
     result = schema.execute(query)
     assert not result.errors
-    assert json.dumps(result.data, sort_keys=True) == \
-        json.dumps(expected, sort_keys=True)
+    assert cmp(result.data, expected) == 0