Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Commit 76473eb

Browse files
author
Brandon Sara
committed
fixed BeanNoSuchBeanDefinitionException thrown by GraphQLWebAutoConfiguration.graphQLObjectMapper when graphql.servlet.use-default-objectmapper is set to false and no bean for ObjectMapperProvider is provided by an application; this also allows users to specify an ObjectMapperConfigurer bean, currently, it will never be used because a ObjectMapperProvider bean is essentially required to always exist
1 parent 0f63510 commit 76473eb

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

graphql-spring-boot-autoconfigure/src/main/java/com/oembedler/moon/graphql/boot/GraphQLWebAutoConfiguration.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import graphql.schema.GraphQLSchema;
3131
import graphql.servlet.*;
3232
import org.springframework.beans.BeansException;
33+
import org.springframework.beans.factory.ObjectProvider;
3334
import org.springframework.beans.factory.annotation.Autowired;
3435
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
3536
import org.springframework.boot.autoconfigure.condition.*;
@@ -194,13 +195,15 @@ public GraphQLQueryInvoker queryInvoker(ExecutionStrategyProvider executionStrat
194195

195196
@Bean
196197
@ConditionalOnMissingBean
197-
public GraphQLObjectMapper graphQLObjectMapper(ObjectMapperProvider objectMapperProvider) {
198+
public GraphQLObjectMapper graphQLObjectMapper(ObjectProvider<ObjectMapperProvider> objectMapperProviderObjectProvider) {
198199
GraphQLObjectMapper.Builder builder = newBuilder();
199200

200201
if (errorHandler != null) {
201202
builder.withGraphQLErrorHandler(errorHandler);
202203
}
203204

205+
ObjectMapperProvider objectMapperProvider = objectMapperProviderObjectProvider.getIfAvailable();
206+
204207
if (objectMapperProvider != null) {
205208
builder.withObjectMapperProvider(objectMapperProvider);
206209
} else if (objectMapperConfigurer != null) {

0 commit comments

Comments
 (0)