persisted document tests

Author: n1ru4l

packages/libraries/core/src/client/http-client.ts

@@ -4,7 +4,7 @@ import { abortSignalAny } from '@graphql-hive/signal';
 import { crypto, fetch, URL } from '@whatwg-node/fetch';
 import type { LegacyLogger } from './types';
 
-interface SharedConfig {
+export interface HttpCallConfig {
   headers: Record<string, string>;
   /**
    * timeout in milliseconds (for each single fetch call)
@@ -32,9 +32,9 @@ interface SharedConfig {
  */
 type ResponseAssertFunction = (response: Response) => boolean;
 
-type RetryOptions = Parameters<typeof asyncRetry>[1];
+export type RetryOptions = Parameters<typeof asyncRetry>[1];
 
-function get(endpoint: string, config: SharedConfig) {
+function get(endpoint: string, config: HttpCallConfig) {
   return makeFetchCall(endpoint, {
     method: 'GET',
     headers: config.headers,
@@ -46,7 +46,7 @@ function get(endpoint: string, config: SharedConfig) {
   });
 }
 
-function post(endpoint: string, data: string | Buffer, config: SharedConfig) {
+function post(endpoint: string, data: string | Buffer, config: HttpCallConfig) {
   return makeFetchCall(endpoint, {
     body: data,
     method: 'POST',
@@ -59,7 +59,7 @@ export const http = {
   post,
 };
 
-function chooseLogger(logger: SharedConfig['logger']): Logger {
+function chooseLogger(logger: HttpCallConfig['logger']): Logger {
   if (!logger) {
     return new Logger({
       writers: [{ write() {} }],

packages/libraries/core/src/client/persisted-documents.ts

@@ -3,7 +3,7 @@ import LRU from 'tiny-lru';
 import { Logger } from '@graphql-hive/logger';
 import CircuitBreaker from '../circuit-breaker/circuit.js';
 import { defaultCircuitBreakerConfiguration } from './circuit-breaker.js';
-import { http } from './http-client.js';
+import { http, HttpCallConfig } from './http-client.js';
 import type { PersistedDocumentsConfiguration } from './types';
 
 type HeadersObject = {
@@ -24,6 +24,8 @@ export function createPersistedDocuments(
   config: PersistedDocumentsConfiguration & {
     logger: Logger;
     fetch?: typeof fetch;
+    retry?: HttpCallConfig['retry'];
+    timeout?: HttpCallConfig['retry'];
   },
 ): PersistedDocuments {
   const persistedDocumentsCache = LRU<string>(config.cache ?? 10_000);
@@ -60,6 +62,7 @@ export function createPersistedDocuments(
             isRequestOk,
             fetchImplementation: config.fetch,
             signal,
+            retry: config.retry,
           })
           .then(async response => {
             if (response.status !== 200) {
@@ -95,14 +98,20 @@ export function createPersistedDocuments(
       .then(async () => {
         const cdnDocumentId = documentId.replaceAll('~', '/');
 
+        let lastError: unknown = null;
+
         for (const breaker of circuitBreakers) {
           try {
             return await breaker.fire(cdnDocumentId);
           } catch (error: unknown) {
             config.logger.debug({ error });
+            lastError = error;
           }
         }
-        throw new Error('Failed to look up artifact.');
+        if (lastError) {
+          config.logger.error({ error: lastError });
+        }
+        throw new Error('Failed to look up persisted operation.');
       })
       .then(result => {
         persistedDocumentsCache.set(documentId, result);