Skip to content

Commit efbe309

Browse files
committed
Modification - Slicer & SlicerPreview - Show null values at zero position when cutNullValues is false
1 parent 3503941 commit efbe309

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

src/atoms/Slicer.vue

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,8 @@ function makeMiniChart(ds, smooth = false) {
483483
const e = Math.min(len, Math.max(s + 1, endMini.value));
484484
485485
const points = ds.map((dp, i) => {
486-
const valid = Number.isFinite(dp);
486+
const val = props.cutNullValues ? dp : dp === null ? 0 : dp;
487+
const valid = Number.isFinite(val);
487488
const x = unitWidthX.value * i + (props.minimapCompact ? 0 : unitWidthX.value / 2);
488489
const y0 =
489490
seriesMin < 0 && seriesMax > 0
@@ -492,9 +493,9 @@ function makeMiniChart(ds, smooth = false) {
492493
493494
return {
494495
x,
495-
y: valid ? mapYSeries(dp) : NaN,
496-
v: dp,
497-
value: valid ? dp : null,
496+
y: valid ? mapYSeries(val) : NaN,
497+
v: val,
498+
value: valid ? val : null,
498499
y0,
499500
i,
500501
};

src/atoms/SlicerPreview.vue

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -495,18 +495,20 @@ function makeMiniChart(ds, smooth = false) {
495495
const e = Math.min(len, Math.max(s + 1, endMini.value));
496496
497497
const points = ds.map((dp, i) => {
498-
const valid = Number.isFinite(dp);
498+
const val = props.cutNullValues ? dp : dp === null ? 0 : dp;
499+
const valid = Number.isFinite(val);
499500
const x = unitWidthX.value * i + (props.minimapCompact ? 0 : unitWidthX.value / 2);
500501
const y0 =
501502
seriesMin < 0 && seriesMax > 0
502503
? mapYSeries(0)
503504
: mapYSeries(0);
504505
506+
505507
return {
506508
x,
507-
y: valid ? mapYSeries(dp) : NaN,
508-
v: dp,
509-
value: valid ? dp : null,
509+
y: valid ? mapYSeries(val) : NaN,
510+
v: val,
511+
value: valid ? val : null,
510512
y0,
511513
i,
512514
};

0 commit comments

Comments
 (0)