Fix - VueUiChord - Fix skeleton not showing when dataset prop is missing

graphieros · graphieros · commit bfdd40e719e1 · 2025-06-21T16:06:15.000+02:00
diff --git a/src/components/vue-ui-chord.vue b/src/components/vue-ui-chord.vue
@@ -200,9 +200,10 @@ function prepareChart() {
 }
 
 function checkDataset(){
-    if (props.dataset.matrix.length < 2) {
+    if (!props.dataset || !Object.hasOwn(props.dataset, 'matrix') || props.dataset.matrix.length < 2) {
         console.warn(`VueUiChord: dataset.matrix requires a minimum of 2 datapoints, for example:\n\nmatrix:[\n  [1, 1],\n  [1, 1]\n]`);
         isDataset.value = false;
+        return;
     }
 
     props.dataset.matrix.forEach((m, i) => {

Original file line number	Diff line number	Diff line change
`@@ -200,9 +200,10 @@ function prepareChart() {`
`200`	`200`	`}`
`201`	`201`
`202`	`202`	`function checkDataset(){`
`203`		`- if (props.dataset.matrix.length < 2) {`
	`203`	`+ if (!props.dataset \|\| !Object.hasOwn(props.dataset, 'matrix') \|\| props.dataset.matrix.length < 2) {`
`204`	`204`	console.warn(`VueUiChord: dataset.matrix requires a minimum of 2 datapoints, for example:\n\nmatrix:[\n [1, 1],\n [1, 1]\n]`);
`205`	`205`	`isDataset.value = false;`
	`206`	`+ return;`
`206`	`207`	`}`
`207`	`208`
`208`	`209`	`props.dataset.matrix.forEach((m, i) => {`