Skip to content

Commit 15dad78

Browse files
committed
address comments
1 parent 2d9dc6a commit 15dad78

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

bigframes/core/nodes.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -822,8 +822,10 @@ def explicitly_ordered(self) -> bool:
822822
@property
823823
def is_star_selection(self) -> bool:
824824
physical_names = tuple(item.name for item in self.source.table.physical_schema)
825-
scan_names = tuple(item.source_id for item in self.scan_list.items)
826-
return physical_names == scan_names
825+
scan_source_id = tuple(item.source_id for item in self.scan_list.items)
826+
scan_id = tuple(item.id.name for item in self.scan_list.items)
827+
828+
return scan_source_id == scan_id and physical_names == scan_source_id
827829

828830
@functools.cached_property
829831
def variables_introduced(self) -> int:

0 commit comments

Comments
 (0)