From 4adf81b8c0e5e7abdec8d7998bb6131c66adf79a Mon Sep 17 00:00:00 2001 From: Thiyagu K Date: Tue, 11 Aug 2026 07:55:30 +0000 Subject: [PATCH 1/6] chore: remove unused form-data and node-fetch dependencies --- handwritten/storage/package.json | 1 - handwritten/storage/system-test/storage.ts | 2 -- 2 files changed, 3 deletions(-) diff --git a/handwritten/storage/package.json b/handwritten/storage/package.json index f337b3b299be..6f8576707693 100644 --- a/handwritten/storage/package.json +++ b/handwritten/storage/package.json @@ -108,7 +108,6 @@ "@types/tmp": "0.2.6", "@types/yargs": "^17.0.35", "c8": "^9.0.0", - "form-data": "^4.0.4", "gapic-tools": "^0.4.0", "gts": "^5.0.0", "jsdoc": "^4.0.4", diff --git a/handwritten/storage/system-test/storage.ts b/handwritten/storage/system-test/storage.ts index cf8074d52671..b8ad6dba689c 100644 --- a/handwritten/storage/system-test/storage.ts +++ b/handwritten/storage/system-test/storage.ts @@ -16,8 +16,6 @@ import assert from 'assert'; import {after, afterEach, before, beforeEach, describe, it} from 'mocha'; import * as crypto from 'crypto'; import * as fs from 'fs'; -import fetch from 'node-fetch'; -import FormData from 'form-data'; import pLimit from 'p-limit'; import {promisify} from 'util'; import * as path from 'path'; From ed7594e3950e859c00bb75d2c96b5b60ff8e3a95 Mon Sep 17 00:00:00 2001 From: Thiyagu K Date: Tue, 11 Aug 2026 07:59:17 +0000 Subject: [PATCH 2/6] chore: remove samples-test script and simplify test execution command --- handwritten/storage/package.json | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/handwritten/storage/package.json b/handwritten/storage/package.json index 6f8576707693..32c9e568ec89 100644 --- a/handwritten/storage/package.json +++ b/handwritten/storage/package.json @@ -47,7 +47,7 @@ "storage" ], "scripts": { - "all-test": "npm test && npm run system-test && npm run samples-test", + "all-test": "npm test && npm run system-test", "benchwrapper": "node bin/benchwrapper.js", "check": "gts check", "clean": "rm -rf build/", @@ -68,10 +68,9 @@ "presystem-test:esm": "npm run compile:esm", "presystem-test": "npm run compile -- --sourceMap", "pretest": "npm run compile -- --sourceMap", - "samples-test": "npm link && cd samples/ && npm link ../ && npm test && cd ../", "system-test:esm": "mkdir -p $HOME/.config && mocha build/esm/system-test --timeout 600000 --exit", "system-test": "mkdir -p $HOME/.config && mocha build/cjs/system-test --timeout 600000 --exit", - "test": "cross-env NODE_OPTIONS=\"--require ./scripts/preload-yargs.cjs --no-deprecation\" c8 mocha build/cjs/test" + "test": "c8 mocha build/cjs/test" }, "dependencies": { "@google-cloud/paginator": "^5.0.0", @@ -124,8 +123,7 @@ "path-to-regexp": "6.3.0", "tmp": "^0.2.0", "typescript": "^5.1.6", - "yargs": "^17.7.2", - "cross-env": "^7.0.3" + "yargs": "^17.7.2" }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/storage" } From 915f1eee6c72ce35a8813de11f365fcd85e5ebc5 Mon Sep 17 00:00:00 2001 From: Thiyagu K Date: Tue, 11 Aug 2026 08:21:55 +0000 Subject: [PATCH 3/6] chore: update test script to preload yargs and add cross-env dependency --- handwritten/storage/package.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/handwritten/storage/package.json b/handwritten/storage/package.json index 32c9e568ec89..78528aa8a4fb 100644 --- a/handwritten/storage/package.json +++ b/handwritten/storage/package.json @@ -70,7 +70,7 @@ "pretest": "npm run compile -- --sourceMap", "system-test:esm": "mkdir -p $HOME/.config && mocha build/esm/system-test --timeout 600000 --exit", "system-test": "mkdir -p $HOME/.config && mocha build/cjs/system-test --timeout 600000 --exit", - "test": "c8 mocha build/cjs/test" + "test": "cross-env NODE_OPTIONS=\"--require ./scripts/preload-yargs.cjs --no-deprecation\" c8 mocha build/cjs/test" }, "dependencies": { "@google-cloud/paginator": "^5.0.0", @@ -123,7 +123,8 @@ "path-to-regexp": "6.3.0", "tmp": "^0.2.0", "typescript": "^5.1.6", - "yargs": "^17.7.2" + "yargs": "^17.7.2", + "cross-env": "^7.0.3" }, "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/storage" } From c9eabf621f9aeb77dd2d8420006be06d5d1fbd56 Mon Sep 17 00:00:00 2001 From: Thiyagu K Date: Tue, 11 Aug 2026 08:28:29 +0000 Subject: [PATCH 4/6] chore: remove node-fetch dependency and associated types --- handwritten/storage/conformance-test/conformanceCommon.ts | 1 - handwritten/storage/package.json | 2 -- 2 files changed, 3 deletions(-) diff --git a/handwritten/storage/conformance-test/conformanceCommon.ts b/handwritten/storage/conformance-test/conformanceCommon.ts index a206ea064fe8..397918a816aa 100644 --- a/handwritten/storage/conformance-test/conformanceCommon.ts +++ b/handwritten/storage/conformance-test/conformanceCommon.ts @@ -19,7 +19,6 @@ import {Bucket, File, HmacKey, Notification, Storage} from '../src/'; import * as crypto from 'crypto'; import * as assert from 'assert'; import {DecorateRequestOptions} from '../src/nodejs-common'; -import fetch from 'node-fetch'; interface RetryCase { instructions: String[]; diff --git a/handwritten/storage/package.json b/handwritten/storage/package.json index 78528aa8a4fb..db9924b81da1 100644 --- a/handwritten/storage/package.json +++ b/handwritten/storage/package.json @@ -100,7 +100,6 @@ "@types/mocha": "^9.1.1", "@types/mockery": "^1.4.29", "@types/node": "^24.0.0", - "@types/node-fetch": "^2.1.3", "@types/proxyquire": "^1.3.28", "@types/request": "^2.48.4", "@types/sinon": "^17.0.0", @@ -115,7 +114,6 @@ "mocha": "^9.2.2", "mockery": "^2.1.0", "nock": "~13.5.0", - "node-fetch": "^2.6.7", "pack-n-play": "^2.0.0", "proxyquire": "^2.1.3", "sinon": "^18.0.0", From 033de68f3069c222fce0d446f5cacadb90529d33 Mon Sep 17 00:00:00 2001 From: Thiyagu K Date: Tue, 11 Aug 2026 08:54:29 +0000 Subject: [PATCH 5/6] chore: update retry-request and teeny-request versions and remove @types/request dependency --- handwritten/storage/package.json | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/handwritten/storage/package.json b/handwritten/storage/package.json index db9924b81da1..f6e7ad22db1d 100644 --- a/handwritten/storage/package.json +++ b/handwritten/storage/package.json @@ -85,8 +85,8 @@ "html-entities": "^2.5.2", "mime": "^3.0.0", "p-limit": "^3.0.1", - "retry-request": "^7.0.0", - "teeny-request": "^9.0.0" + "retry-request": "^8.0.0", + "teeny-request": "^10.0.0" }, "devDependencies": { "@babel/cli": "^7.22.10", @@ -101,7 +101,6 @@ "@types/mockery": "^1.4.29", "@types/node": "^24.0.0", "@types/proxyquire": "^1.3.28", - "@types/request": "^2.48.4", "@types/sinon": "^17.0.0", "@types/tmp": "0.2.6", "@types/yargs": "^17.0.35", From 8e1a019d3ea2eff80b81d6c53f9ea91d355a1483 Mon Sep 17 00:00:00 2001 From: Thiyagu K Date: Mon, 17 Aug 2026 06:16:52 +0000 Subject: [PATCH 6/6] chore: add @types/request to devDependencies in storage package.json --- handwritten/storage/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/handwritten/storage/package.json b/handwritten/storage/package.json index ecfe3f50cc7d..d3e1bf4166a9 100644 --- a/handwritten/storage/package.json +++ b/handwritten/storage/package.json @@ -101,6 +101,7 @@ "@types/mockery": "^1.4.29", "@types/node": "^24.0.0", "@types/proxyquire": "^1.3.28", + "@types/request": "^2.48.12", "@types/sinon": "^17.0.0", "@types/tmp": "0.2.6", "@types/yargs": "^17.0.35",