From 74d347b391ba287c536c9e924eb4d986dd1f9463 Mon Sep 17 00:00:00 2001 From: Chris Kennelly CA Date: Mon, 31 Aug 2026 15:43:01 -0700 Subject: [PATCH] Cleanup TCMALLOC_PER_CPU_CACHE_SIZE_1MB experiment. PiperOrigin-RevId: 974118025 --- tcmalloc/experiment_config.h | 2 -- tcmalloc/static_vars.cc | 3 --- 2 files changed, 5 deletions(-) diff --git a/tcmalloc/experiment_config.h b/tcmalloc/experiment_config.h index f2556e586..70adeae5d 100644 --- a/tcmalloc/experiment_config.h +++ b/tcmalloc/experiment_config.h @@ -25,7 +25,6 @@ enum class Experiment : int { // go/keep-sorted start TCMALLOC_DEMAND_CYCLE_120S, // TODO: b/540987155 - Complete experiment. TCMALLOC_HUGE_REGION_ADAPTIVE_RELEASE, // TODO: b/535197873 - Complete experiment. - TCMALLOC_PER_CPU_CACHE_SIZE_1MB, // TODO: b/514747820 - Complete experiment. TCMALLOC_PGHO_EXPERIMENT, // TODO: b/460486507 - Complete experiment. TCMALLOC_REUSE_SIZE_CLASSES_ABLATION, // TODO: b/524296402 - Complete experiment. TCMALLOC_SONIC_MADVISE_SAMPLED_ALLOCATIONS_HOLDBACK, // TODO: b/540945006 - Complete experiment. @@ -56,7 +55,6 @@ inline constexpr ExperimentConfig experiments[] = { // go/keep-sorted start {Experiment::TCMALLOC_DEMAND_CYCLE_120S, "TCMALLOC_DEMAND_CYCLE_120S"}, {Experiment::TCMALLOC_HUGE_REGION_ADAPTIVE_RELEASE, "TCMALLOC_HUGE_REGION_ADAPTIVE_RELEASE"}, - {Experiment::TCMALLOC_PER_CPU_CACHE_SIZE_1MB, "TCMALLOC_PER_CPU_CACHE_SIZE_1MB"}, {Experiment::TCMALLOC_PGHO_EXPERIMENT, "TCMALLOC_PGHO_EXPERIMENT"}, {Experiment::TCMALLOC_REUSE_SIZE_CLASSES_ABLATION, "TCMALLOC_REUSE_SIZE_CLASSES_ABLATION"}, {Experiment::TCMALLOC_SONIC_MADVISE_SAMPLED_ALLOCATIONS_HOLDBACK, "TCMALLOC_SONIC_MADVISE_SAMPLED_ALLOCATIONS_HOLDBACK", /*brittle=*/false, /*force_disable=*/false, /*rollout_lower_bound=*/0, /*rollout_upper_bound=*/0.5}, diff --git a/tcmalloc/static_vars.cc b/tcmalloc/static_vars.cc index 5d4a838c0..36545b2b4 100644 --- a/tcmalloc/static_vars.cc +++ b/tcmalloc/static_vars.cc @@ -210,9 +210,6 @@ ABSL_ATTRIBUTE_COLD ABSL_ATTRIBUTE_NOINLINE void Static::SlowInitIfNecessary() { } (void)subtle::percpu::IsFast(); PerCpuState::state().Init(); - if (IsExperimentActive(Experiment::TCMALLOC_PER_CPU_CACHE_SIZE_1MB)) { - cpu_cache_.SetCacheLimit(/*v=*/1024 * 1024); - } numa_topology_.Init(); CacheTopology::Instance().Init();