Enable and fix a few more lints (#388)

Author: kevmoo

analysis_options.yaml

@@ -37,6 +37,7 @@ linter:
     - constant_identifier_names
     - control_flow_in_finally
     - curly_braces_in_flow_control_structures
+    - depend_on_referenced_packages
     - directives_ordering
     - empty_catches
     - empty_constructor_bodies
@@ -49,13 +50,17 @@ linter:
     - join_return_with_assignment
     - library_names
     - library_prefixes
+    - library_private_types_in_public_api
     - lines_longer_than_80_chars
     - list_remove_unrelated_type
     - literal_only_boolean_expressions
     - missing_whitespace_between_adjacent_strings
     - no_duplicate_case_values
+    - no_leading_underscores_for_library_prefixes
+    - no_leading_underscores_for_local_identifiers
     - no_runtimeType_toString
     - non_constant_identifier_names
+    - null_check_on_nullable_type_parameter
     - null_closures
     - omit_local_variable_types
     - only_throw_errors
@@ -93,20 +98,25 @@ linter:
     - prefer_void_to_null
     - provide_deprecation_message
     - recursive_getters
+    - require_trailing_commas
     - slash_for_doc_comments
     - sort_pub_dependencies
+    - sort_unnamed_constructors_first
     - test_types_in_equals
     - throw_in_finally
     - type_annotate_public_apis
     - type_init_formals
     - unawaited_futures
     - unnecessary_brace_in_string_interps
     - unnecessary_const
+    - unnecessary_constructor_name
     - unnecessary_getters_setters
     - unnecessary_lambdas
+    - unnecessary_late
     - unnecessary_new
     - unnecessary_null_aware_assignments
     - unnecessary_null_in_if_null_operators
+    - unnecessary_nullable_for_final_variable_declarations
     - unnecessary_overrides
     - unnecessary_parenthesis
     - unnecessary_statements
@@ -117,6 +127,6 @@ linter:
     - use_is_even_rather_than_modulo
     - use_rethrow_when_possible
     - use_string_buffers
+    - use_super_parameters
     - valid_regexps
     - void_checks
-    - require_trailing_commas

mono_repo/lib/src/mono_config.dart

@@ -35,15 +35,6 @@ class MonoConfig {
   final String? selfValidateStage;
   final GitHubConfig github;
 
-  MonoConfig._({
-    required this.githubConditionalStages,
-    required this.mergeStages,
-    required this.prettyAnsi,
-    required this.pubAction,
-    required this.selfValidateStage,
-    required this.github,
-  });
-
   factory MonoConfig({
     required Set<String> mergeStages,
     required bool prettyAnsi,
@@ -63,6 +54,15 @@ class MonoConfig {
     );
   }
 
+  MonoConfig._({
+    required this.githubConditionalStages,
+    required this.mergeStages,
+    required this.prettyAnsi,
+    required this.pubAction,
+    required this.selfValidateStage,
+    required this.github,
+  });
+
   factory MonoConfig.fromJson(Map json) {
     final unsupportedKeys =
         json.keys.where((k) => !_allowedMonoConfigKeys.contains(k)).toList();

mono_repo/lib/src/root_config.dart

@@ -61,8 +61,6 @@ class RootConfig extends ListBase<PackageConfig> {
   final MonoConfig monoConfig;
   final List<PackageConfig> _configs;
 
-  RootConfig._(this.rootDirectory, this.monoConfig, this._configs);
-
   factory RootConfig({String? rootDirectory, bool recursive = true}) {
     rootDirectory ??= p.current;
 
@@ -103,6 +101,8 @@ class RootConfig extends ListBase<PackageConfig> {
     );
   }
 
+  RootConfig._(this.rootDirectory, this.monoConfig, this._configs);
+
   @override
   int get length => _configs.length;