From 113ba8d9c255c6cbc55f7627d0da114241f890d5 Mon Sep 17 00:00:00 2001 From: hchiam Date: Wed, 26 Mar 2025 20:57:51 -0600 Subject: [PATCH 1/3] make small-cls table render properly in both jekyll abd github --- review/developer/small-cls.md | 39 ++++++++++++++++++++++++++++------- 1 file changed, 32 insertions(+), 7 deletions(-) diff --git a/review/developer/small-cls.md b/review/developer/small-cls.md index 0501c550..c571aefd 100644 --- a/review/developer/small-cls.md +++ b/review/developer/small-cls.md @@ -164,13 +164,38 @@ To take this a step further, you could combine these approaches and chart out an implementation plan like this, where each cell is its own standalone CL. Starting from the model (at the bottom) and working up to the client: -| Layer | Feature: Multiplication | Feature: Division | -| ------- | ------------------------- | ------------------------------- | -| Client | Add button | Add button | -| API | Add endpoint | Add endpoint | -| Service | Implement transformations | Share transformation logic with | -: : : multiplication : -| Model | Add proto definition | Add proto definition | + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
LayerFeature: MultiplicationFeature: Division
ClientAdd buttonAdd button
APIAdd endpointAdd endpoint
ServiceImplement transformationsShare transformation logic with
multiplication
ModelAdd proto definitionAdd proto definition
## Separate Out Refactorings {#refactoring} From 67b022ed810a6efa3cd719e5c32a141761d17eac Mon Sep 17 00:00:00 2001 From: hchiam Date: Wed, 26 Mar 2025 21:04:46 -0600 Subject: [PATCH 2/3] make handling-comments backtick markdown render properly in both jekyll and github (copy what is done in cl-descriptions) --- review/developer/handling-comments.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/review/developer/handling-comments.md b/review/developer/handling-comments.md index cb43fb98..7df7d590 100644 --- a/review/developer/handling-comments.md +++ b/review/developer/handling-comments.md @@ -64,11 +64,11 @@ If you can't answer that question, ask the reviewer for clarification. And then, if you understand the comments but disagree with them, it's important to think collaboratively, not combatively or defensively: -```txt {.bad} +``` {.bad} Bad: "No, I'm not going to do that." ``` -```txt {.good} +``` {.good} Good: "I went with X because of [these pros/cons] with [these tradeoffs] My understanding is that using Y would be worse because of [these reasons]. Are you suggesting that Y better serves the original tradeoffs, that we should From 7b800110575ac8cadc126580154589df0a9b83a3 Mon Sep 17 00:00:00 2001 From: hchiam Date: Wed, 26 Mar 2025 21:08:48 -0600 Subject: [PATCH 3/3] make small-cls table render properly in both jekyll abd github (with backticks like how cl-descriptions has it already rendering correctly in both) --- review/developer/small-cls.md | 41 ++++++++--------------------------- 1 file changed, 9 insertions(+), 32 deletions(-) diff --git a/review/developer/small-cls.md b/review/developer/small-cls.md index c571aefd..8b5adc53 100644 --- a/review/developer/small-cls.md +++ b/review/developer/small-cls.md @@ -164,38 +164,15 @@ To take this a step further, you could combine these approaches and chart out an implementation plan like this, where each cell is its own standalone CL. Starting from the model (at the bottom) and working up to the client: - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
LayerFeature: MultiplicationFeature: Division
ClientAdd buttonAdd button
APIAdd endpointAdd endpoint
ServiceImplement transformationsShare transformation logic with
multiplication
ModelAdd proto definitionAdd proto definition
+``` +| Layer | Feature: Multiplication | Feature: Division | +| ------- | ------------------------- | ------------------------------- | +| Client | Add button | Add button | +| API | Add endpoint | Add endpoint | +| Service | Implement transformations | Share transformation logic with | +: : : multiplication : +| Model | Add proto definition | Add proto definition | +``` ## Separate Out Refactorings {#refactoring}