Make the specialized types created for bind/goog.partial anonymous

blickly · copybara-github · commit a5c257778ac3 · 2020-08-11T09:20:32.000-07:00
These types are unique from the original definitions, so they should rightly
be a new anonymous type rather than conflated with the original type.

PiperOrigin-RevId: 326034992
diff --git a/src/com/google/javascript/jscomp/TypeInference.java b/src/com/google/javascript/jscomp/TypeInference.java
@@ -1974,6 +1974,7 @@ private void updateBind(Node n) {
             FunctionType.builder(registry)
                 .copyFromOtherFunction(callTargetFn)
                 .withTypeOfThis(thisType.toObjectType())
+                .withSourceNode(null)
                 .buildAndResolve();
         target.setJSType(callTargetFn);
       }
@@ -1990,6 +1991,7 @@ private void updateBind(Node n) {
           FunctionType.builder(registry)
               .copyFromOtherFunction(bindType)
               .withReturnType(returnType)
+              .withSourceNode(null)
               .buildAndResolve();
       n.getFirstChild().setJSType(bindType);
     }
@@ -2715,4 +2717,3 @@ private static TypedVar getDeclaredVar(FlowScope scope, String name) {
     return ((TypedScope) scope.getDeclarationScope()).getVar(name);
   }
 }
-

Original file line number	Diff line number	Diff line change
`@@ -1974,6 +1974,7 @@ private void updateBind(Node n) {`
`1974`	`1974`	`FunctionType.builder(registry)`
`1975`	`1975`	`.copyFromOtherFunction(callTargetFn)`
`1976`	`1976`	`.withTypeOfThis(thisType.toObjectType())`
	`1977`	`+ .withSourceNode(null)`
`1977`	`1978`	`.buildAndResolve();`
`1978`	`1979`	`target.setJSType(callTargetFn);`
`1979`	`1980`	`}`
`@@ -1990,6 +1991,7 @@ private void updateBind(Node n) {`
`1990`	`1991`	`FunctionType.builder(registry)`
`1991`	`1992`	`.copyFromOtherFunction(bindType)`
`1992`	`1993`	`.withReturnType(returnType)`
	`1994`	`+ .withSourceNode(null)`
`1993`	`1995`	`.buildAndResolve();`
`1994`	`1996`	`n.getFirstChild().setJSType(bindType);`
`1995`	`1997`	`}`
`@@ -2715,4 +2717,3 @@ private static TypedVar getDeclaredVar(FlowScope scope, String name) {`
`2715`	`2717`	`return ((TypedScope) scope.getDeclarationScope()).getVar(name);`
`2716`	`2718`	`}`
`2717`	`2719`	`}`
`2718`		`-`