chore: groups unconvert files to a package

Author: ldez

test/testdata/unconvert.go renamed to pkg/golinters/unconvert/testdata/unconvert.go

@@ -1,4 +1,4 @@
-package golinters
+package unconvert
 
 import (
 	"sync"
@@ -12,14 +12,14 @@ import (
 	"github.com/golangci/golangci-lint/pkg/result"
 )
 
-const unconvertName = "unconvert"
+const name = "unconvert"
 
-func NewUnconvert(settings *config.UnconvertSettings) *goanalysis.Linter {
+func New(settings *config.UnconvertSettings) *goanalysis.Linter {
 	var mu sync.Mutex
 	var resIssues []goanalysis.Issue
 
 	analyzer := &analysis.Analyzer{
-		Name: unconvertName,
+		Name: name,
 		Doc:  goanalysis.TheOnlyanalyzerDoc,
 		Run: func(pass *analysis.Pass) (any, error) {
 			issues := runUnconvert(pass, settings)
@@ -37,7 +37,7 @@ func NewUnconvert(settings *config.UnconvertSettings) *goanalysis.Linter {
 	}
 
 	return goanalysis.NewLinter(
-		unconvertName,
+		name,
 		"Remove unnecessary type conversions",
 		[]*analysis.Analyzer{analyzer},
 		nil,
@@ -54,7 +54,7 @@ func runUnconvert(pass *analysis.Pass, settings *config.UnconvertSettings) []goa
 		issues = append(issues, goanalysis.NewIssue(&result.Issue{
 			Pos:        position,
 			Text:       "unnecessary conversion",
-			FromLinter: unconvertName,
+			FromLinter: name,
 		}, pass))
 	}
 

pkg/golinters/unconvert.go renamed to pkg/golinters/unconvert/unconvert.go

@@ -0,0 +1,11 @@
+package unconvert
+
+import (
+	"testing"
+
+	"github.com/golangci/golangci-lint/test/testshared/integration"
+)
+
+func TestFromTestdata(t *testing.T) {
+	integration.RunTestdata(t)
+}

pkg/golinters/unconvert/unconvert_integration_test.go

@@ -99,6 +99,7 @@ import (
 	"github.com/golangci/golangci-lint/pkg/golinters/testpackage"
 	"github.com/golangci/golangci-lint/pkg/golinters/thelper"
 	"github.com/golangci/golangci-lint/pkg/golinters/tparallel"
+	"github.com/golangci/golangci-lint/pkg/golinters/unconvert"
 	"github.com/golangci/golangci-lint/pkg/golinters/whitespace"
 	"github.com/golangci/golangci-lint/pkg/golinters/zerologlint"
 	"github.com/golangci/golangci-lint/pkg/lint/linter"
@@ -748,7 +749,7 @@ func (LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 			WithPresets(linter.PresetBugs).
 			WithURL(""),
 
-		linter.NewConfig(golinters.NewUnconvert(&cfg.LintersSettings.Unconvert)).
+		linter.NewConfig(unconvert.New(&cfg.LintersSettings.Unconvert)).
 			WithSince("v1.0.0").
 			WithLoadForGoAnalysis().
 			WithPresets(linter.PresetStyle).