From 8ffbcd88956753c1f9777b5fd02cfedd77eccd68 Mon Sep 17 00:00:00 2001 From: Valentin Maerten Date: Mon, 3 Aug 2026 22:01:34 +0200 Subject: [PATCH 1/2] ci(renovate): skip Go deps requiring a newer go directive Renovate never proposed the `go 1.25.10` -> `go 1.26.4` bump seen in #2943 directly: the `gomodTidy` post-update option produced it. A digest update to the indirect dep github.com/planetscale/vtprotobuf pulled in a revision whose own go.mod declares `go 1.26.4`, and `go mod tidy` raises our directive to match. That in turn breaks every 1.25.x job in the CI matrix, which runs with GOTOOLCHAIN=local. Set constraintsFiltering=strict on the gomod manager so Renovate filters out candidate releases whose go directive exceeds ours, rather than pinning offending packages one at a time. --- .github/renovate.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/renovate.json b/.github/renovate.json index 0b63169da5..92ce1a0918 100644 --- a/.github/renovate.json +++ b/.github/renovate.json @@ -50,6 +50,11 @@ "matchManagers": ["gomod"], "matchDepTypes": ["golang"], "enabled": false + }, + { + "description": "Skip releases whose own `go` directive exceeds ours. Without this, `gomodTidy` propagates their requirement into our go.mod and breaks the older Go versions in the CI matrix.", + "matchManagers": ["gomod"], + "constraintsFiltering": "strict" } ] } From c9412771cb20b97cb6fc0dc6152113ae5b3b635e Mon Sep 17 00:00:00 2001 From: Valentin Maerten Date: Mon, 3 Aug 2026 22:01:37 +0200 Subject: [PATCH 2/2] fix(experiments): format the invalid experiment value with %d InvalidValueError.Value is an int but was formatted with %q, which renders it as a quoted rune literal ('\x02') instead of the number. Go 1.26's stricter vet now reports it, failing both the lint job and the experiments package build. --- experiments/errors.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/experiments/errors.go b/experiments/errors.go index 68a5f8b872..850220c4f9 100644 --- a/experiments/errors.go +++ b/experiments/errors.go @@ -16,7 +16,7 @@ type InvalidValueError struct { func (err InvalidValueError) Error() string { return fmt.Sprintf( - "task: Experiment %q has an invalid value %q (allowed values: %s)", + "task: Experiment %q has an invalid value %d (allowed values: %s)", err.Name, err.Value, strings.Join(slicesext.Convert(err.AllowedValues, strconv.Itoa), ", "),