Skip to content

Commit 363d4bc

Browse files
committed
code refactor
1 parent df60924 commit 363d4bc

File tree

3 files changed

+7
-21
lines changed

3 files changed

+7
-21
lines changed

gs/internal/gs_bean/bean.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -192,15 +192,6 @@ func (d *BeanRuntime) Callable() gs.Callable {
192192
return nil
193193
}
194194

195-
// Match checks if the bean matches the given typeName and beanName.
196-
func (d *BeanRuntime) Match(beanName string) bool {
197-
nameIsSame := false
198-
if beanName == "" || d.name == beanName {
199-
nameIsSame = true
200-
}
201-
return nameIsSame
202-
}
203-
204195
// String returns a string representation of the bean.
205196
func (d *BeanRuntime) String() string {
206197
return d.name

gs/internal/gs_core/core.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ type BeanRuntime interface {
5757
Value() reflect.Value
5858
Interface() interface{}
5959
Callable() gs.Callable
60-
Match(beanName string) bool
6160
Status() gs_bean.BeanStatus
6261
String() string
6362
}
@@ -574,11 +573,8 @@ func (c *resolvingStage) Find(s gs.BeanSelector) ([]gs.CondBean, error) {
574573
}
575574
}
576575
}
577-
if s.Name != "" {
578-
ok := b.Match(s.Name)
579-
if !ok {
580-
continue
581-
}
576+
if s.Name != "" && s.Name != b.Name() {
577+
continue
582578
}
583579
if err := c.resolveBean(b); err != nil {
584580
return nil, err

gs/internal/gs_core/wire.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ func (c *Container) findBeans(s gs.BeanSelector) ([]BeanRuntime, error) {
285285
}
286286
var ret []BeanRuntime
287287
for _, b := range beans {
288-
if b.Match(s.Name) {
288+
if s.Name == b.Name() {
289289
ret = append(ret, b)
290290
}
291291
}
@@ -309,10 +309,9 @@ func (c *Container) getBean(t reflect.Type, tag wireTag, stack *WiringStack) (Be
309309
if b.Status() == gs_bean.StatusDeleted {
310310
continue
311311
}
312-
if !b.Match(tag.beanName) {
313-
continue
312+
if tag.beanName == "" || tag.beanName == b.Name() {
313+
foundBeans = append(foundBeans, b)
314314
}
315-
foundBeans = append(foundBeans, b)
316315
}
317316

318317
// When a specific bean name is provided, find it by name.
@@ -324,7 +323,7 @@ func (c *Container) getBean(t reflect.Type, tag wireTag, stack *WiringStack) (Be
324323
if !b.Type().AssignableTo(t) {
325324
continue
326325
}
327-
if !b.Match(tag.beanName) {
326+
if tag.beanName != "" && tag.beanName != b.Name() {
328327
continue
329328
}
330329

@@ -429,7 +428,7 @@ func (c *Container) getBeans(t reflect.Type, tags []wireTag, nullable bool, stac
429428

430429
var founds []int
431430
for i, b := range beans {
432-
if b.Match(item.beanName) {
431+
if item.beanName == b.Name() {
433432
founds = append(founds, i)
434433
}
435434
}

0 commit comments

Comments
 (0)