osfs: max out defaultDirectoryMode

a reprise of #104, with added tests

Limited the scope of the CreateWithChroot tests to OsFs, because
MemFs creates parent directories with bonkers permissions.

drive-by: add Makefile variables for `make test-coverage` to run successfully

Author: 0xDEC0DE

.gitignore

@@ -1,3 +1,3 @@
-/coverage.txt
+/coverage.*
 /vendor
 /build/

Makefile

@@ -3,6 +3,10 @@ GOCMD = go
 GOTEST = $(GOCMD) test 
 WASIRUN_WRAPPER := $(CURDIR)/scripts/wasirun-wrapper
 
+# Coverage
+COVERAGE_REPORT := coverage.out
+COVERAGE_MODE := count
+
 GOLANGCI_VERSION ?= v1.64.5
 TOOLS_BIN := $(shell mkdir -p build/tools && realpath build/tools)
 

osfs/os.go

@@ -14,7 +14,7 @@ import (
 )
 
 const (
-	defaultDirectoryMode = 0o755
+	defaultDirectoryMode = 0o777
 	defaultCreateMode    = 0o666
 )
 

osfs/os_bound_test.go

@@ -1285,8 +1285,24 @@ func TestRename(t *testing.T) {
 	require.NoError(t, err)
 	require.NoError(t, f.Close())
 
-	err = fs.Rename(oldFile, newFile)
-	require.NoError(t, err)
+	if runtime.GOOS != "windows" {
+		reset_umask := umask(2)
+		err = fs.Rename(oldFile, newFile)
+		require.NoError(t, err)
+		reset_umask()
+
+		di, err := os.Stat(filepath.Dir(filepath.Join(dir, newFile)))
+		require.NoError(t, err)
+		assert.NotNil(di)
+		expected := 0o775
+		actual := int(di.Mode().Perm())
+		assert.Equal(
+			expected, actual, "Permission mismatch - expected: 0o%o, actual: 0o%o", expected, actual,
+		)
+	} else {
+		err = fs.Rename(oldFile, newFile)
+		require.NoError(t, err)
+	}
 
 	fi, err := os.Stat(filepath.Join(dir, newFile))
 	require.NoError(t, err)

osfs/os_chroot_test.go

@@ -47,3 +47,25 @@ func TestCapabilities(t *testing.T) {
 	caps := billy.Capabilities(fs)
 	assert.Equal(t, billy.AllCapabilities, caps)
 }
+
+func TestCreateWithChroot(t *testing.T) {
+	if runtime.GOOS == "windows" {
+		t.Skip("Skipping POSIX umask tests on Windows")
+	}
+	fs, _ := setup(t)
+	reset_umask := umask(2)
+	chroot, _ := fs.Chroot("foo")
+	f, err := chroot.Create("bar")
+	require.NoError(t, err)
+	require.NoError(t, f.Close())
+	assert.Equal(t, f.Name(), "bar")
+	reset_umask()
+
+	di, err := fs.Stat("foo")
+	require.NoError(t, err)
+	expected := 0o775
+	actual := int(di.Mode().Perm())
+	assert.Equal(
+		t, expected, actual, "Permission mismatch - expected: 0o%o, actual: 0o%o", expected, actual,
+	)
+}