Fixes preview tabs when clicking files in details

Adds dblclick to open in non-preview tabs

Author: eamodio

src/webviews/apps/commitDetails/components/gl-details-base.ts

@@ -429,7 +429,7 @@ export class GlDetailsBase extends LitElement {
 		const [file] = e.detail.context;
 		const event = new CustomEvent('file-open', {
 			detail: this.getEventDetail(file, {
-				preview: false,
+				preview: !e.detail.dblClick,
 				viewColumn: e.detail.altKey ? BesideViewColumn : undefined,
 			}),
 		});
@@ -442,7 +442,7 @@ export class GlDetailsBase extends LitElement {
 		const [file] = e.detail.context;
 		const event = new CustomEvent('file-open-on-remote', {
 			detail: this.getEventDetail(file, {
-				preview: false,
+				preview: !e.detail.dblClick,
 				viewColumn: e.detail.altKey ? BesideViewColumn : undefined,
 			}),
 		});
@@ -455,7 +455,7 @@ export class GlDetailsBase extends LitElement {
 		const [file] = e.detail.context;
 		const event = new CustomEvent('file-compare-working', {
 			detail: this.getEventDetail(file, {
-				preview: false,
+				preview: !e.detail.dblClick,
 				viewColumn: e.detail.altKey ? BesideViewColumn : undefined,
 			}),
 		});
@@ -468,7 +468,7 @@ export class GlDetailsBase extends LitElement {
 		const [file] = e.detail.context;
 		const event = new CustomEvent('file-compare-previous', {
 			detail: this.getEventDetail(file, {
-				preview: false,
+				preview: !e.detail.dblClick,
 				viewColumn: e.detail.altKey ? BesideViewColumn : undefined,
 			}),
 		});
@@ -491,7 +491,7 @@ export class GlDetailsBase extends LitElement {
 		const [file] = e.detail.context;
 		const event = new CustomEvent('file-stage', {
 			detail: this.getEventDetail(file, {
-				preview: false,
+				preview: !e.detail.dblClick,
 				viewColumn: e.detail.altKey ? BesideViewColumn : undefined,
 			}),
 		});
@@ -504,7 +504,7 @@ export class GlDetailsBase extends LitElement {
 		const [file] = e.detail.context;
 		const event = new CustomEvent('file-unstage', {
 			detail: this.getEventDetail(file, {
-				preview: false,
+				preview: !e.detail.dblClick,
 				viewColumn: e.detail.altKey ? BesideViewColumn : undefined,
 			}),
 		});

src/webviews/apps/plus/patchDetails/components/gl-draft-details.ts

@@ -745,7 +745,7 @@ export class GlDraftDetails extends GlTreeBase {
 		this.emit('gl-patch-file-compare-working', {
 			...file,
 			showOptions: {
-				preview: false,
+				preview: !e.detail.dblClick,
 				viewColumn: e.detail.altKey ? BesideViewColumn : undefined,
 			},
 		});
@@ -758,7 +758,7 @@ export class GlDraftDetails extends GlTreeBase {
 		this.emit('gl-patch-file-open', {
 			...file,
 			showOptions: {
-				preview: false,
+				preview: !e.detail.dblClick,
 				viewColumn: e.detail.altKey ? BesideViewColumn : undefined,
 			},
 		});

src/webviews/apps/plus/patchDetails/components/gl-patch-create.ts

@@ -774,7 +774,7 @@ export class GlPatchCreate extends GlTreeBase {
 		this.emit('gl-patch-file-open', {
 			...file,
 			showOptions: {
-				preview: false,
+				preview: !e.detail.dblClick,
 				viewColumn: e.detail.altKey ? BesideViewColumn : undefined,
 			},
 		});
@@ -787,7 +787,7 @@ export class GlPatchCreate extends GlTreeBase {
 		this.emit('gl-patch-file-stage', {
 			...file,
 			showOptions: {
-				preview: false,
+				preview: !e.detail.dblClick,
 				viewColumn: e.detail.altKey ? BesideViewColumn : undefined,
 			},
 		});
@@ -800,7 +800,7 @@ export class GlPatchCreate extends GlTreeBase {
 		this.emit('gl-patch-file-unstage', {
 			...file,
 			showOptions: {
-				preview: false,
+				preview: !e.detail.dblClick,
 				viewColumn: e.detail.altKey ? BesideViewColumn : undefined,
 			},
 		});

src/webviews/apps/shared/components/tree/tree-generator.ts

@@ -78,6 +78,7 @@ export class GlTreeGenerator extends GlElement {
 				.icon=${action.icon}
 				.label=${action.label}
 				@click=${(e: MouseEvent) => this.onTreeItemActionClicked(e, model, action)}
+				@dblclick=${(e: MouseEvent) => this.onTreeItemActionDblClicked(e, model, action)}
 			></action-item>`;
 		});
 	}
@@ -170,6 +171,19 @@ export class GlTreeGenerator extends GlElement {
 			metaKey: e.metaKey,
 		});
 	}
+
+	private onTreeItemActionDblClicked(e: MouseEvent, model: TreeModelFlat, action: TreeItemAction) {
+		e.stopPropagation();
+		this.emit('gl-tree-generated-item-action-clicked', {
+			node: model,
+			context: model.context,
+			action: action,
+			dblClick: true,
+			altKey: e.altKey,
+			ctrlKey: e.ctrlKey,
+			metaKey: e.metaKey,
+		});
+	}
 }
 
 function flattenTree(tree: TreeModel, children: number = 1, position: number = 1): TreeModelFlat[] {