Removes remaining Launchpad in Editor preferences and commands

Author: d13

package.json

@@ -1351,13 +1351,6 @@
 						"scope": "window",
 						"order": 160
 					},
-					"gitlens.launchpad.indicator.openInEditor": {
-						"type": "boolean",
-						"default": false,
-						"markdownDescription": "Specifies whether to open _Launchpad_ as an editor tab when clicking on the status bar indicator",
-						"scope": "window",
-						"order": 170
-					},
 					"gitlens.launchpad.allowMultiple": {
 						"type": "boolean",
 						"default": true,
@@ -9915,7 +9908,7 @@
 				},
 				{
 					"command": "gitlens.launchpad.split",
-					"when": "gitlens:enabled && config.gitlens.launchpad.allowMultiple"
+					"when": "false && gitlens:enabled && config.gitlens.launchpad.allowMultiple"
 				},
 				{
 					"command": "gitlens.launchpad.indicator.toggle",

src/commands/quickCommand.buttons.ts

@@ -147,11 +147,6 @@ export const OpenOnWebQuickInputButton: QuickInputButton = {
 	tooltip: 'Open on gitkraken.dev',
 };
 
-export const OpenInEditorQuickInputButton: QuickInputButton = {
-	iconPath: new ThemeIcon('link-external'),
-	tooltip: 'Open in Editor',
-};
-
 export const LaunchpadSettingsQuickInputButton: QuickInputButton = {
 	iconPath: new ThemeIcon('gear'),
 	tooltip: 'Launchpad Settings',

src/config.ts

@@ -98,7 +98,6 @@ export interface Config {
 		readonly staleThreshold: number | null;
 		readonly indicator: {
 			readonly enabled: boolean;
-			readonly openInEditor: boolean;
 			readonly icon: 'default' | 'group';
 			readonly label: false | 'item' | 'counts';
 			readonly useColors: boolean;

src/constants.telemetry.ts

@@ -237,7 +237,6 @@ export type TelemetryEvents = {
 		'config.launchpad.ignoredOrganizations': number;
 		'config.launchpad.ignoredRepositories': number;
 		'config.launchpad.indicator.enabled': boolean;
-		'config.launchpad.indicator.openInEditor': boolean;
 		'config.launchpad.indicator.icon': 'default' | 'group';
 		'config.launchpad.indicator.label': false | 'item' | 'counts';
 		'config.launchpad.indicator.useColors': boolean;

src/plus/focus/focusIndicator.ts

@@ -76,10 +76,7 @@ export class FocusIndicator implements Disposable {
 	private async onConfigurationChanged(e: ConfigurationChangeEvent) {
 		if (!configuration.changed(e, 'launchpad.indicator')) return;
 
-		if (
-			configuration.changed(e, 'launchpad.indicator.openInEditor') ||
-			configuration.changed(e, 'launchpad.indicator.label')
-		) {
+		if (configuration.changed(e, 'launchpad.indicator.label')) {
 			this.updateStatusBarCommand();
 		}
 
@@ -309,18 +306,16 @@ export class FocusIndicator implements Disposable {
 
 	private updateStatusBarCommand() {
 		const labelType = configuration.get('launchpad.indicator.label') ?? 'item';
-		this._statusBarFocus.command = configuration.get('launchpad.indicator.openInEditor')
-			? 'gitlens.showFocusPage'
-			: {
-					title: 'Open Launchpad',
-					command: Commands.ShowLaunchpad,
-					arguments: [
-						{
-							source: 'launchpad-indicator',
-							state: { selectTopItem: labelType === 'item' },
-						} satisfies Omit<FocusCommandArgs, 'command'>,
-					],
-			  };
+		this._statusBarFocus.command = {
+			title: 'Open Launchpad',
+			command: Commands.ShowLaunchpad,
+			arguments: [
+				{
+					source: 'launchpad-indicator',
+					state: { selectTopItem: labelType === 'item' },
+				} satisfies Omit<FocusCommandArgs, 'command'>,
+			],
+		};
 	}
 
 	private updateStatusBarWithItems(tooltip: MarkdownString, categorizedItems: FocusItem[] | undefined) {

src/plus/focus/focusProvider.ts

@@ -918,7 +918,6 @@ export class FocusProvider implements Disposable {
 			'config.launchpad.ignoredOrganizations': cfg.ignoredOrganizations?.length ?? 0,
 			'config.launchpad.ignoredRepositories': cfg.ignoredRepositories?.length ?? 0,
 			'config.launchpad.indicator.enabled': cfg.indicator.enabled,
-			'config.launchpad.indicator.openInEditor': cfg.indicator.openInEditor,
 			'config.launchpad.indicator.icon': cfg.indicator.icon,
 			'config.launchpad.indicator.label': cfg.indicator.label,
 			'config.launchpad.indicator.useColors': cfg.indicator.useColors,