From 0449836e77da7989a6a6996a3da7d97c4ad30a58 Mon Sep 17 00:00:00 2001 From: Adam Setch Date: Wed, 14 Oct 2026 07:36:30 -0400 Subject: [PATCH] chore: include type-checking in the standard check command `pnpm check` (the command CONTRIBUTING tells contributors to run before pushing) ran only formatting and linting, while CI also runs `tsc --noEmit` in a separate step. So a local `pnpm check` could pass and CI then fail on a type error. Fold `vp exec tsc --noEmit` into `check` and `check:fix`, reusing the exact command CI runs. `CONTRIBUTING.md` already names `pnpm check`, so no doc change is needed; CI's `vp run check` (lint.yml) now type-checks too. --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index f69633f55..5879f7e0e 100644 --- a/package.json +++ b/package.json @@ -62,8 +62,8 @@ "package:linux": "electron-builder --linux", "package:macos": "electron-builder --mac", "package:win": "electron-builder --win", - "check": "vp check", - "check:fix": "vp check --fix", + "check": "vp check && vp exec tsc --noEmit", + "check:fix": "vp check --fix && vp exec tsc --noEmit", "lint": "vp lint --fix", "lint:check": "vp lint", "format": "vp fmt",