fix: tray color error (#2386)

Signed-off-by: Adam Setch <adam.setch@outlook.com>

Author: setchy

src/renderer/context/App.tsx

@@ -189,7 +189,9 @@ export const AppProvider = ({ children }: { children: ReactNode }) => {
   useEffect(() => {
     setUseUnreadActiveIcon(settings.useUnreadActiveIcon);
     setUseAlternateIdleIcon(settings.useAlternateIdleIcon);
-    setTrayIconColorAndTitle(unreadNotificationCount, settings);
+
+    const trayCount = status === 'error' ? -1 : unreadNotificationCount;
+    setTrayIconColorAndTitle(trayCount, settings);
   }, [
     settings.showNotificationsCountInTray,
     settings.useUnreadActiveIcon,

src/renderer/hooks/useNotifications.ts

@@ -13,7 +13,6 @@ import {
   markNotificationThreadAsDone,
   markNotificationThreadAsRead,
 } from '../utils/api/client';
-import { updateTrayColor } from '../utils/comms';
 import {
   areAllAccountErrorsSame,
   doesAllAccountsHaveErrors,
@@ -91,7 +90,6 @@ export const useNotifications = (): NotificationsState => {
         const accountError = fetchedNotifications[0].error;
         setStatus('error');
         setGlobalError(allAccountErrorsAreSame ? accountError : null);
-        updateTrayColor(-1);
         return;
       }