-
Notifications
You must be signed in to change notification settings - Fork 35
Closed
Labels
Description
Objective
Add the firewall property to the network configuration in included files to restore security feature parity with main workflows.
Context
Priority: HIGH
Category: Security / Feature Parity
Currently:
- Main Schema: network field has properties
allowedandfirewall - Included Schema: network field has property
allowedonly
This prevents included files from configuring advanced network security rules, limiting defense-in-depth architecture for modular workflows.
Approach
- Open
pkg/parser/schemas/included_file_schema.json - Locate the
networkfield definition (should be in oneOf structure) - Find the object form (oneOf[1]) that has
allowedproperty - Add
firewallproperty alongsideallowedwith same schema as main_workflow_schema.json - Copy the firewall property definition from main schema (should include patterns, rules, etc.)
- Rebuild binary with
make build - Test with included file using firewall configuration
Files to Modify
- Update:
pkg/parser/schemas/included_file_schema.json- Add
firewallproperty to network.oneOf[1].properties - Match firewall schema structure from main_workflow_schema.json
- Add
Acceptance Criteria
- Included schema network field supports
firewallproperty - Firewall schema structure matches main workflow schema
- Test workflows with firewall rules compile successfully
- Network security features work identically in included files
Testing
Create test included file:
---
network:
allowed:
- "api.github.com"
firewall:
rules:
- pattern: "*.example.com"
action: block
---Verify compilation and validation.
AI generated by Planning Assistant
Related to #7944
AI generated by Plan Command for discussion #7935
Copilot