Skip to content

[plan] Add network firewall configuration to included_file_schema.json #7947

@github-actions

Description

@github-actions

Objective

Add the firewall property to the network configuration in included files to restore security feature parity with main workflows.

Context

Priority: HIGH
Category: Security / Feature Parity

Currently:

  • Main Schema: network field has properties allowed and firewall
  • Included Schema: network field has property allowed only

This prevents included files from configuring advanced network security rules, limiting defense-in-depth architecture for modular workflows.

Approach

  1. Open pkg/parser/schemas/included_file_schema.json
  2. Locate the network field definition (should be in oneOf structure)
  3. Find the object form (oneOf[1]) that has allowed property
  4. Add firewall property alongside allowed with same schema as main_workflow_schema.json
  5. Copy the firewall property definition from main schema (should include patterns, rules, etc.)
  6. Rebuild binary with make build
  7. Test with included file using firewall configuration

Files to Modify

  • Update: pkg/parser/schemas/included_file_schema.json
    • Add firewall property to network.oneOf[1].properties
    • Match firewall schema structure from main_workflow_schema.json

Acceptance Criteria

  • Included schema network field supports firewall property
  • Firewall schema structure matches main workflow schema
  • Test workflows with firewall rules compile successfully
  • Network security features work identically in included files

Testing

Create test included file:

---
network:
  allowed:
    - "api.github.com"
  firewall:
    rules:
      - pattern: "*.example.com"
        action: block
---

Verify compilation and validation.


AI generated by Planning Assistant
Related to #7944

AI generated by Plan Command for discussion #7935

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions