Unable to "Merge without waiting for requirements to be met (bypass rules)" #228
Replies: 2 comments
|
Adding this in case it might be useful here, as we’ve hit what looks like a similar underlying issue through a slightly different path. We’re using Aviator’s MergeQueue rather than the manual “Merge without waiting for requirements to be met (bypass rules)” button. Aviator merges stacked PRs programmatically via the GitHub App/API and is configured as a bypass actor on our ruleset for the required-reviews rule. With the bypass mode set to “Always”, merges of non-bottom PRs in a stack were failing with: This happened despite the Aviator App having bypass permissions, and with no manual UI interaction involved. Switching the Aviator App’s bypass mode from “Always” to “Exempt” resolved our issue. My understanding, based on GitHub’s migration docs, is that “Always” still evaluates the rule and records a bypass event, whereas “Exempt” skips evaluation of the rule entirely for that actor. If that understanding is correct, it seems possible that the problem is specifically related to how the required-reviews rule is being (re-)evaluated for non-bottom stack PRs when using “Always”, rather than being purely a limitation of the web UI. It might therefore be worth checking whether the distinction between “Always” and “Exempt” also explains the missing bypass option in the web UI, or whether these are two separate issues that happen to produce a similar symptom. |

Uh oh!
There was an error while loading. Please reload this page.
Duplicate issues
Desired outcome
Have the same functionality to "Merge without waiting for requirements to be met (bypass rules)" for GitHub Stacked PRs.
The problem & reproduction
When a PR at the bottom of the stack is out-of-date with the base branch (
mainin this case) and is approved, you can merge it if your branch protections allow you to do so. All PRs above it in the stack lose their approval due to the rebase (this is expected).Switching over to the next PR in the stack that has now become the bottom of the stack, it's unapproved (which is expected), however, you lose the ability to "Merge without waiting for requirements to be met (bypass rules)".
The workaround solution was to:
All reactions