Add debug logging to identify problematic IDP group

- Gracefully handle empty results when fetching IDP groups
- Add tests

Author: dpmex4527

src/Octoshift/Commands/CreateTeam/CreateTeamCommandHandler.cs

@@ -44,15 +44,32 @@ public async Task Handle(CreateTeamCommandArgs args)
         }
         else
         {
+            _log.LogInformation($"Attempting to link team '{args.TeamName}' to IDP group '{args.IdpGroup}'");
+
             var members = await _githubApi.GetTeamMembers(args.GithubOrg, teamSlug);
+            _log.LogInformation($"Found {members.Count()} existing team members to remove before linking to IDP group");
 
             foreach (var member in members)
             {
+                _log.LogInformation($"Removing team member '{member}' from team '{teamSlug}'");
                 await _githubApi.RemoveTeamMember(args.GithubOrg, teamSlug, member);
             }
 
-            var idpGroupId = await _githubApi.GetIdpGroupId(args.GithubOrg, args.IdpGroup);
+            _log.LogInformation($"Searching for IDP group '{args.IdpGroup}' in organization '{args.GithubOrg}'");
+
+            int idpGroupId;
+            try
+            {
+                idpGroupId = await _githubApi.GetIdpGroupId(args.GithubOrg, args.IdpGroup);
+                _log.LogInformation($"Found IDP group '{args.IdpGroup}' with ID: {idpGroupId}");
+            }
+            catch (OctoshiftCliException ex)
+            {
+                _log.LogError($"Failed to find IDP group: {ex.Message}");
+                throw;
+            }
 
+            _log.LogInformation($"Adding IDP group '{args.IdpGroup}' (ID: {idpGroupId}) to team '{teamSlug}'");
             await _githubApi.AddEmuGroupToTeam(args.GithubOrg, teamSlug, idpGroupId);
 
             _log.LogSuccess("Successfully linked team to Idp group");

src/Octoshift/Services/GithubApi.cs

@@ -390,7 +390,7 @@ mutation startRepositoryMigration(
                     $lockSource: Boolean)";
         var gql = @"
                 startRepositoryMigration(
-                    input: { 
+                    input: {
                         sourceId: $sourceId,
                         ownerId: $ownerId,
                         sourceRepositoryUrl: $sourceRepositoryUrl,
@@ -456,7 +456,7 @@ mutation startOrganizationMigration (
                         $targetEnterpriseId: ID!,
                         $sourceAccessToken: String!)";
         var gql = @"
-                startOrganizationMigration( 
+                startOrganizationMigration(
                     input: {
                         sourceOrgUrl: $sourceOrgUrl,
                         targetOrgName: $targetOrgName,
@@ -620,8 +620,15 @@ public virtual async Task<int> GetIdpGroupId(string org, string groupName)
     {
         var url = $"{_apiUrl}/orgs/{org.EscapeDataString()}/external-groups";
 
-        var group = await _client.GetAllAsync(url, data => (JArray)data["groups"])
-            .SingleAsync(x => string.Equals((string)x["group_name"], groupName, StringComparison.OrdinalIgnoreCase));
+        var allGroups = await _client.GetAllAsync(url, data => (JArray)data["groups"]).ToListAsync();
+
+        var group = allGroups.SingleOrDefault(x => string.Equals((string)x["group_name"], groupName, StringComparison.OrdinalIgnoreCase));
+
+        if (group == null)
+        {
+            var availableGroups = string.Join(", ", allGroups.Select(g => $"'{g["group_name"]}'"));
+            throw new OctoshiftCliException($"IDP group '{groupName}' not found in organization '{org}'. Available groups: {availableGroups}");
+        }
 
         return (int)group["group_id"];
     }
@@ -1077,7 +1084,7 @@ mutation abortRepositoryMigration(
                 )";
         var gql = @"
                 abortRepositoryMigration(
-                    input: { 
+                    input: {
                         migrationId: $migrationId
                     })
                    { success }";