From 97a02ed9037db367f24d64b1755af7de1698ec05 Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Wed, 18 Feb 2026 17:55:02 +0000 Subject: [PATCH 1/2] Rust: Remove MacroCallTargetStats from rust/diagnostic/database-quality. --- rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql | 2 -- 1 file changed, 2 deletions(-) diff --git a/rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql b/rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql index 02933b3bd5f6..9cd244c8c5d8 100644 --- a/rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql +++ b/rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql @@ -12,8 +12,6 @@ import codeql.util.Unit private predicate diagnostic(string msg, float value, float threshold) { CallTargetStatsReport::percentageOfOk(msg, value) and threshold = 50 or - MacroCallTargetStatsReport::percentageOfOk(msg, value) and threshold = 50 - or ExprTypeStatsReport::percentageOfOk(msg, value) and threshold = 20 } From fd5c5b5635dabd2f29c94f15bcfc30d40dfb6567 Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Wed, 18 Feb 2026 17:59:49 +0000 Subject: [PATCH 2/2] Rust: Change note. --- rust/ql/src/change-notes/2026-02-18-database-quality.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 rust/ql/src/change-notes/2026-02-18-database-quality.md diff --git a/rust/ql/src/change-notes/2026-02-18-database-quality.md b/rust/ql/src/change-notes/2026-02-18-database-quality.md new file mode 100644 index 000000000000..ef2f1b3139c2 --- /dev/null +++ b/rust/ql/src/change-notes/2026-02-18-database-quality.md @@ -0,0 +1,4 @@ +--- +category: minorAnalysis +--- +* The macro resolution metric has been removed from `rust/diagnostic/database-quality`. This metric was found to be an unreliable indicator of database quality in many cases, leading to false alarms on the tool status page.