unified: Handle explicit .init at call site

Author: asgerf

unified/ql/lib/codeql/unified/internal/mad/LegacyMaD.qll

@@ -77,7 +77,11 @@ private predicate methodCallSelector(CallExpr call, string name, string argLabel
 
 pragma[nomagic]
 private predicate constructorCallSelector(CallExpr call, string name, string argLabels) {
-  name = getQualifiedNameFromExpr(call.getCallee()) and
+  (
+    if call.getCallee().(MemberAccessExpr).getMemberName() = "init"
+    then name = getQualifiedNameFromExpr(call.getCallee().(MemberAccessExpr).getBase())
+    else name = getQualifiedNameFromExpr(call.getCallee())
+  ) and
   argLabels = getArgLabelsFromCall(call)
 }
 

unified/ql/test/library-tests/mad/test.expected

@@ -7,15 +7,19 @@ isSink
 | test.swift:23:20:23:25 | string | regex-use |
 | test.swift:24:20:24:25 | string | regex-use |
 | test.swift:71:37:71:49 | encodedOffset | string-length |
+| test.swift:72:42:72:54 | encodedOffset | string-length |
 | test.swift:76:24:76:36 | encryptionKey | encryption-key |
 | test.swift:77:18:77:24 | fileURL | path-injection |
+| test.swift:88:24:88:36 | encryptionKey | encryption-key |
+| test.swift:89:18:89:24 | fileURL | path-injection |
 | test.swift:100:24:100:36 | encryptionKey | encryption-key |
 | test.swift:101:18:101:24 | fileURL | path-injection |
 | test.swift:107:23:107:34 | seedFilePath | path-injection |
 isSource
 | test.swift:4:5:4:27 | String(...) | remote |
 | test.swift:5:5:5:44 | String(...) | remote |
 | test.swift:6:5:6:48 | String(...) | remote |
+| test.swift:7:5:7:32 | ... .init(...) | remote |
 | test.swift:9:5:9:34 | String(...) | local |
 | test.swift:10:5:12:24 | String(...) | local |
 | test.swift:13:5:15:28 | String(...) | local |

unified/ql/test/library-tests/mad/test.swift

@@ -4,7 +4,7 @@ func test(url: URL, string: String) {
     String(contentsOf: url)  // $ isSource=remote
     String(contentsOf: url, encoding: .utf8)  // $ isSource=remote
     String(contentsOf: url, usedEncoding: .utf8)  // $ isSource=remote
-    String.init(contentsOf: url)  // $ MISSING: isSource=remote
+    String.init(contentsOf: url)  // $ isSource=remote
 
     String(contentsOfFile: string)  // $ isSource=local isSink=path-injection
     String(
@@ -69,7 +69,7 @@ func testQualifiedConstructors(
     seedFilePath: String
 ) {
     _ = String.Index(encodedOffset: encodedOffset)  // $ isSink=string-length
-    _ = String.Index.init(encodedOffset: encodedOffset)  // $ MISSING: isSink=string-length
+    _ = String.Index.init(encodedOffset: encodedOffset)  // $ isSink=string-length
 
     _ = Realm.Configuration(
         deleteRealmIfMigrationNeeded: false,
@@ -85,8 +85,8 @@ func testQualifiedConstructors(
 
     _ = Realm.Configuration.init(
         deleteRealmIfMigrationNeeded: false,
-        encryptionKey: encryptionKey,  // $ MISSING: isSink=encryption-key
-        fileURL: fileURL,  // $ MISSING: isSink=path-injection
+        encryptionKey: encryptionKey,  // $ isSink=encryption-key
+        fileURL: fileURL,  // $ isSink=path-injection
         inMemoryIdentifier: nil,
         migrationBlock: nil,
         objectTypes: nil,