Skip to content

Commit a95acc1

Browse files
committed
Unified: Handle GenericTypeExpr in static name binding
1 parent 3ed93cc commit a95acc1

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

‎unified/ql/lib/codeql/unified/internal/StaticNameBinding.qll‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ class NameBindingNode extends TNameBindingNode {
121121
Identifier getIdentifierFromRef(AstNode n) {
122122
result = n.(PotentialLocalNameAccess)
123123
or
124+
result = n.(GenericTypeExpr).getBase()
125+
or
124126
result = n.(MemberAccessExpr).getMemberNameNode()
125127
}
126128

‎unified/ql/test/library-tests/static-name-binding/generics.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ enum GenericEnum<T> {
55

66
func testGenericEnum() {
77
let intValue = GenericEnum.value(42) // $ access=GenericEnum access=GenericEnum.value
8-
let stringValue = GenericEnum<String>.novalue // $ access=GenericEnum access=String $ MISSING: access=GenericEnum.novalue
8+
let stringValue = GenericEnum<String>.novalue // $ access=GenericEnum access=String access=GenericEnum.novalue
99
}

0 commit comments

Comments
 (0)