Skip to content

Commit 6d93b42

Browse files
committed
C#: Reclassify some sources as AspNetRemoteFlowSource.
1 parent 6e2ba88 commit 6d93b42

File tree

1 file changed

+4
-3
lines changed
  • csharp/ql/lib/semmle/code/csharp/security/dataflow/flowsources

1 file changed

+4
-3
lines changed

csharp/ql/lib/semmle/code/csharp/security/dataflow/flowsources/Remote.qll

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ class WcfRemoteFlowSource extends RemoteFlowSource, DataFlow::ParameterNode {
104104
}
105105

106106
/** A data flow source of remote user input (ASP.NET web service). */
107-
class AspNetServiceRemoteFlowSource extends RemoteFlowSource, DataFlow::ParameterNode {
107+
class AspNetServiceRemoteFlowSource extends AspNetRemoteFlowSource, DataFlow::ParameterNode {
108108
AspNetServiceRemoteFlowSource() {
109109
exists(Method m |
110110
m.getAParameter() = this.getParameter() and
@@ -116,7 +116,8 @@ class AspNetServiceRemoteFlowSource extends RemoteFlowSource, DataFlow::Paramete
116116
}
117117

118118
/** A data flow source of remote user input (ASP.NET request message). */
119-
class SystemNetHttpRequestMessageRemoteFlowSource extends RemoteFlowSource, DataFlow::ExprNode {
119+
class SystemNetHttpRequestMessageRemoteFlowSource extends AspNetRemoteFlowSource, DataFlow::ExprNode
120+
{
120121
SystemNetHttpRequestMessageRemoteFlowSource() {
121122
this.getType() instanceof SystemWebHttpRequestMessageClass
122123
}
@@ -166,7 +167,7 @@ class MicrosoftOwinRequestRemoteFlowSource extends RemoteFlowSource, DataFlow::E
166167
}
167168

168169
/** A parameter to an Mvc controller action method, viewed as a source of remote user input. */
169-
class ActionMethodParameter extends RemoteFlowSource, DataFlow::ParameterNode {
170+
class ActionMethodParameter extends AspNetRemoteFlowSource, DataFlow::ParameterNode {
170171
ActionMethodParameter() {
171172
exists(Parameter p |
172173
p = this.getParameter() and

0 commit comments

Comments
 (0)