Add test with spurious results for go/unreachable-statement

Author: owen-mc

go/ql/test/query-tests/RedundantCode/UnreachableStatement/CONSISTENCY/CfgConsistency.expected

@@ -1,5 +1,6 @@
 consistencyOverview
-| deadEnd | 11 |
+| deadEnd | 12 |
+| missingInNodeForPostOrInOrder | 1 |
 deadEnd
 | main.go:17:2:17:10 | select statement |
 | main.go:109:2:109:10 | select statement |
@@ -12,3 +13,6 @@ deadEnd
 | main.go:157:2:157:10 | select statement |
 | main.go:164:2:164:10 | select statement |
 | main.go:168:2:168:10 | select statement |
+| main.go:200:5:200:11 | implicit-field:0 selection of value |
+missingInNodeForPostOrInOrder
+| main.go:200:5:200:11 | selection of value |

go/ql/test/query-tests/RedundantCode/UnreachableStatement/UnreachableStatement.expected

@@ -11,3 +11,4 @@
 | main.go:153:2:153:22 | return statement | This statement is unreachable. |
 | main.go:159:2:159:43 | return statement | This statement is unreachable. |
 | main.go:171:2:171:14 | expression statement | This statement is unreachable. |
+| main.go:203:2:203:14 | return statement | This statement is unreachable. |

go/ql/test/query-tests/RedundantCode/UnreachableStatement/main.go

@@ -186,4 +186,21 @@ func test23() {
 	unreachable() // OK: deliberately unreachable
 }
 
+type (
+	embedded  struct{}
+	recursive struct {
+		*embedded
+		value int
+		*recursive
+	}
+)
+
+func test24(x *recursive) []int {
+	values := []int{0}
+	if x.value != 0 {
+		values = append(values, x.value)
+	}
+	return values // $ SPURIOUS: Alert // BUG: reachable because value is a direct field of recursive
+}
+
 func main() {}