Skip to content

Commit 0fc2502

Browse files
Copilotfelickz
andcommitted
Revert query file change and fix script to handle empty code-quality-extended suites
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
1 parent 7b6b703 commit 0fc2502

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

actions/ql/src/Violations Of Best Practice/CodeQL/UnnecessaryUseOfAdvancedConfig.ql

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@
55
* @problem.severity recommendation
66
* @precision high
77
* @id actions/unnecessary-use-of-advanced-config
8-
* @tags quality
8+
* @tags actions
99
* maintainability
10-
* actions
1110
*/
1211

1312
import codeql.actions.Violations_Of_Best_Practices.DefaultableCodeQLInitiatlizeActionQuery

misc/scripts/generate-code-scanning-query-list.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,8 @@ def subprocess_run(cmd):
184184
sys.exit("You can use '--ignore-missing-query-packs' to ignore this error")
185185

186186
# Exception for the code-quality suites, which might be empty, but must be resolvable.
187-
if pack == 'code-quality' and queries_subp == '':
188-
print(f'Warning: skipping empty suite code-quality', file=sys.stderr)
187+
if pack in ['code-quality', 'code-quality-extended'] and queries_subp == '':
188+
print(f'Warning: skipping empty suite {pack}', file=sys.stderr)
189189
continue
190190

191191
# Investigate metadata for every query by using 'codeql resolve metadata'

0 commit comments

Comments
 (0)