Skip to content

Commit d7a8941

Browse files
committed
Release function returns a boolean. Stable version
1 parent 4420abc commit d7a8941

File tree

2 files changed

+21
-14
lines changed

2 files changed

+21
-14
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "github-release-notes",
3-
"version": "0.2.0",
3+
"version": "0.2.2",
44
"description": "Node module to publish release notes based on commits between the last two tags.",
55
"main": "./github-release-notes.js",
66
"scripts": {

src/index.js

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,20 @@ var Github = require('github-api');
1717
* }
1818
*/
1919
function makeRelease(gren, releaseOptions) {
20-
gren.repo.makeRelease(releaseOptions, function (err, release) {
21-
if(err) {
22-
var responseText = JSON.parse(err.request.responseText);
23-
console.error(
24-
responseText.message + '\n'
25-
+ responseText.errors[0].code
26-
);
27-
} else {
28-
console.info(release.tag_name + ' successfully created!');
29-
}
20+
return new Promise(function (resolve, reject) {
21+
gren.repo.makeRelease(releaseOptions, function (err, release) {
22+
if(err) {
23+
var responseText = JSON.parse(err.request.responseText);
24+
console.error(
25+
responseText.message + '\n'
26+
+ responseText.errors[0].code
27+
);
28+
reject(false);
29+
} else {
30+
console.log(release.tag_name + ' successfully created!');
31+
resolve(true);
32+
}
33+
});
3034
});
3135
}
3236

@@ -78,7 +82,7 @@ function prepareRelease(gren, tags, commitMessages) {
7882
prerelease: gren.options.prerelease || false
7983
};
8084

81-
makeRelease(gren, releaseOptions);
85+
return makeRelease(gren, releaseOptions);
8286
}
8387

8488
/**
@@ -212,7 +216,7 @@ function GithubReleaseNotes(options) {
212216
GithubReleaseNotes.prototype.release = function() {
213217
var that = this;
214218

215-
getLatestRelease(this)
219+
return getLatestRelease(this)
216220
.then(function (releaseTagName) {
217221
return getLastTags(that, releaseTagName);
218222
})
@@ -227,7 +231,10 @@ GithubReleaseNotes.prototype.release = function() {
227231
return getCommitsBetweenTwo(that, data[1], data[0]);
228232
})
229233
.then(function (commitMessages) {
230-
prepareRelease(that, tags, commitMessages);
234+
return prepareRelease(that, tags, commitMessages);
235+
})
236+
.then(function (success) {
237+
return success;
231238
})
232239
.catch(function (error) {
233240
console.error(error);

0 commit comments

Comments
 (0)