Commit 7e87e5a
committed
ci: also build the artifact that links to the runtime DLL
It is no longer clear from the documentation at
https://sevenzip.osdn.jp/chm/cmdline/switches/sfx.htm that the
`7zSD.sfx` links to MSVCRT.dll (as opposed to `7zS.sfx`, which
apparently does not). StackOverflow to the rescue:
https://stackoverflow.com/a/15770961/1860823
Since Git for Windows wants to use the minimum amount of
dependencies in the self-extracting installers (such as the
Portable Git), it used to use the `7zSD.sfx` artifact.
However, since we rebuilt the SFX component using a recent
Visual C version, which does not link to `msvcrt.dll` but to
`vcruntime140.dll`, we ran into problems:
git-for-windows/git#1127
In essence, we cannot rely on the presence of `vcruntime140.dll`
(where we could always rely on `msvcrt.dll` being there).
So we have to go back to using `7zS.sfx`, even if it is a bit
larger. As of August 2023, the difference is 155 vs 233
kilobytes.
Nevertheless, let's build both artifacts.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>1 parent 9506d99 commit 7e87e5a
1 file changed
+16
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
13 | 26 | | |
14 | 27 | | |
15 | 28 | | |
| |||
18 | 31 | | |
19 | 32 | | |
20 | 33 | | |
21 | | - | |
| 34 | + | |
22 | 35 | | |
23 | 36 | | |
24 | 37 | | |
25 | 38 | | |
26 | | - | |
27 | | - | |
| 39 | + | |
| 40 | + | |
0 commit comments