Skip to content

Commit a168f31

Browse files
author
TheSnoozer
committed
the deploy and corveralls jobs need the integrations-tests to run - however those are skipped on push events which might result in the jobs never being run?
1 parent 1d88a1b commit a168f31

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

.github/workflows/default-tests.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ jobs:
66
checkstyle:
77
name: Run checkstyle
88
runs-on: ubuntu-latest
9-
if: github.event_name == 'pull_request'
109
steps:
1110
- uses: actions/checkout@v1
1211
- name: Set up JDK 8
@@ -26,7 +25,6 @@ jobs:
2625
name: Run basic test with Java ${{ matrix.java_version }}
2726
runs-on: ubuntu-latest
2827
needs: checkstyle
29-
if: github.event_name == 'pull_request'
3028
strategy:
3129
matrix:
3230
java_version: ['8', '9', '10', '11', '12', '13']
@@ -50,7 +48,6 @@ jobs:
5048
name: Run integration test with Java ${{ matrix.java_version }} and Maven ${{ matrix.maven_version }}
5149
runs-on: ubuntu-latest
5250
needs: checkstyle
53-
if: github.event_name == 'pull_request'
5451
strategy:
5552
matrix:
5653
java_version: ['8']
@@ -101,7 +98,7 @@ jobs:
10198
name: Run coveralls
10299
runs-on: ubuntu-latest
103100
needs: integration-test
104-
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }}
101+
if: ${{ github.event_name != 'pull_request' && (startsWith(github.ref, 'refs/tags/') || github.ref == 'refs/heads/master') }}
105102

106103
steps:
107104
- uses: actions/checkout@v1
@@ -123,7 +120,7 @@ jobs:
123120
name: Deploy snapshot
124121
runs-on: ubuntu-latest
125122
needs: integration-test
126-
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }}
123+
if: ${{ github.event_name != 'pull_request' && (startsWith(github.ref, 'refs/tags/') || github.ref == 'refs/heads/master') }}
127124

128125
steps:
129126
- uses: actions/checkout@v1

0 commit comments

Comments
 (0)