Merge pull request #19 from ginkelsoft-development/fix/elasticsearch-error-handling

fix: add proper error handling with exceptions to Elasticsearch service

Author: ginkelsoft-development

src/Services/ElasticsearchService.php

@@ -49,29 +49,41 @@ public function __construct(?string $host = null)
      * @param  string  $index  The Elasticsearch index name.
      * @param  string  $id  The unique document ID.
      * @param  array<string, mixed>  $body  The document body to be stored.
-     * @return bool  True if successful, false otherwise.
+     * @return void
+     *
+     * @throws \RuntimeException if the request fails
      */
-    public function indexDocument(string $index, string $id, array $body): bool
+    public function indexDocument(string $index, string $id, array $body): void
     {
         $url = "{$this->host}/{$index}/_doc/{$id}";
         $response = Http::put($url, $body);
 
-        return $response->successful();
+        if (!$response->successful()) {
+            throw new \RuntimeException(
+                "Failed to index document to Elasticsearch [{$url}]: " . $response->body()
+            );
+        }
     }
 
     /**
      * Delete a document from Elasticsearch by its ID.
      *
      * @param  string  $index  The Elasticsearch index name.
      * @param  string  $id  The document ID to delete.
-     * @return bool  True if successful, false otherwise.
+     * @return void
+     *
+     * @throws \RuntimeException if the request fails
      */
-    public function deleteDocument(string $index, string $id): bool
+    public function deleteDocument(string $index, string $id): void
     {
         $url = "{$this->host}/{$index}/_doc/{$id}";
         $response = Http::delete($url);
 
-        return $response->successful();
+        if (!$response->successful()) {
+            throw new \RuntimeException(
+                "Failed to delete document from Elasticsearch [{$url}]: " . $response->body()
+            );
+        }
     }
 
     /**
@@ -80,12 +92,20 @@ public function deleteDocument(string $index, string $id): bool
      * @param  string  $index  The Elasticsearch index name.
      * @param  array<string, mixed>  $query  The Elasticsearch query body.
      * @return array<int, mixed>  The array of matching documents (hits).
+     *
+     * @throws \RuntimeException if the request fails
      */
     public function search(string $index, array $query): array
     {
         $url = "{$this->host}/{$index}/_search";
         $response = Http::post($url, $query);
 
+        if (!$response->successful()) {
+            throw new \RuntimeException(
+                "Failed to search Elasticsearch [{$url}]: " . $response->body()
+            );
+        }
+
         return $response->json('hits.hits', []);
     }