Missing constructor symbols in elf

[jayvdb]

When I build some Python packages, and then run object's nm on the generated .o files, some symbols are missing

e.g. https://pypi.org/project/pyzmq/ , https://pypi.org/project/gevent/

> nm build/temp.linux-x86_64-3.7/zmq/backend/cython/message.o | grep __pyx_wrapperbase_3zmq_7backend_6cython_7message_5Frame_2__init__
0000000000000038 C __pyx_wrapperbase_3zmq_7backend_6cython_7message_5Frame_2__init__
> ~/projects/rust/object/target/debug/examples/nm build/temp.linux-x86_64-3.7/zmq/backend/cython/message.o | grep __pyx_wrapperbase_3zmq_7backend_6cython_7message_5Frame_2__init__
0000000000000020 0000000000000038 U __pyx_wrapperbase_3zmq_7backend_6cython_7message_5Frame_2__init__

This is blocking indygreg/PyOxidizer#183

https://pypi.org/project/psutil/ appears to be a different problem.

[philipc]

Need to add support for common symbols (SHN_COMMON), both for reading and writing.

[jayvdb]

I see it at https://github.com/m4b/goblin/blob/495475b9be1ca8d1df0ce40d7dceffcae9cdede4/src/elf/section_header.rs#L80

Is that enough in goblin, or does it also need an enhancement?

[philipc]

That's the definition, but that by itself doesn't do anything. It also needs to be handled during reading and writing.