Commit d92b140
fix(crons): Fix MockCheckInTimeline positioning to match real timeline behavior (#103264)
The mock timeline was calculating positions incorrectly, causing
misalignment with the grid lines. This fix makes it match how the real
CheckInTimeline positions ticks.
Key changes:
1. Use `periodStart` instead of `start` (which is underscanStart) as the
base timestamp calculations
2. Add `startOffset` (underscanWidth) to all positions to account for
the underscan area on the left
3. Use `elapsedMinutes` from the config for consistency with grid
calculations
4. Use `timelineWidth` which excludes the underscan width
This matches the positioning logic in mergeBuckets where ticks are
positioned relative to the usable timeline area, not the full container width.1 parent 3a9ecd5 commit d92b140
File tree
2 files changed
+16
-14
lines changed- static/app/components/checkInTimeline
2 files changed
+16
-14
lines changedLines changed: 14 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | 47 | | |
57 | 48 | | |
58 | 49 | | |
| |||
109 | 100 | | |
110 | 101 | | |
111 | 102 | | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
119 | | - | |
120 | | - | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
126 | | - | |
| 126 | + | |
| 127 | + | |
127 | 128 | | |
128 | 129 | | |
129 | 130 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
| 94 | + | |
94 | 95 | | |
95 | 96 | | |
96 | 97 | | |
| |||
0 commit comments