ref: fix various types for sentry.monitors

Author: asottile-sentry

src/sentry/monitors/clock_tasks/check_missed.py

@@ -107,6 +107,9 @@ def mark_environment_missing(monitor_environment_id: int, ts: datetime):
         return
 
     monitor = monitor_environment.monitor
+    # next_checkin must be set, since detecting this monitor as missed means
+    # there must have been an initial user check-in.
+    assert monitor_environment.next_checkin is not None
     expected_time = monitor_environment.next_checkin
 
     # add missed checkin.

src/sentry/monitors/endpoints/base_monitor_details.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 from django.db import router, transaction
-from django.db.models import F
+from django.db.models import F, QuerySet
 from django.db.models.functions import TruncMinute
 from django.utils.crypto import get_random_string
 from rest_framework.request import Request
@@ -184,6 +184,7 @@ def delete_monitor(self, request: Request, project: Project, monitor: Monitor) -
                 ).values_list("id", flat=True)
             )
         with transaction.atomic(router.db_for_write(MonitorEnvironment)):
+            monitor_objects: QuerySet[MonitorEnvironment] | QuerySet[Monitor]
             if env_ids:
                 monitor_objects = (
                     MonitorEnvironment.objects.filter(
@@ -206,7 +207,9 @@ def delete_monitor(self, request: Request, project: Project, monitor: Monitor) -
                 event = audit_log.get_event_id("MONITOR_ENVIRONMENT_REMOVE")
                 issue_alert_rule_id = None
             else:
-                monitor_objects = Monitor.objects.filter(id=monitor.id).exclude(
+                monitor_objects = monitor_monitor_objects = Monitor.objects.filter(
+                    id=monitor.id
+                ).exclude(
                     status__in=[
                         ObjectStatus.PENDING_DELETION,
                         ObjectStatus.DELETION_IN_PROGRESS,
@@ -215,11 +218,13 @@ def delete_monitor(self, request: Request, project: Project, monitor: Monitor) -
                 event = audit_log.get_event_id("MONITOR_REMOVE")
 
                 # Mark rule for deletion if present and monitor is being deleted
-                monitor = monitor_objects.first()
-                issue_alert_rule_id = monitor.config.get("alert_rule_id") if monitor else None
+                first_monitor = monitor_monitor_objects.first()
+                issue_alert_rule_id = (
+                    first_monitor.config.get("alert_rule_id") if first_monitor else None
+                )
 
             # create copy of queryset as update will remove objects
-            monitor_objects_list = list(monitor_objects)
+            monitor_objects_list: list[MonitorEnvironment | Monitor] = list(monitor_objects)
             if not monitor_objects or not monitor_objects.update(
                 status=ObjectStatus.PENDING_DELETION
             ):

src/sentry/monitors/endpoints/organization_monitor_index_stats.py

@@ -108,7 +108,7 @@ def get(self, request: Request, organization) -> Response:
             # Otherwise we can skip this and default to the "production" environment label.
             eids = list(filter(lambda eid: eid is not None, monitor_environment_map.values()))
             if eids:
-                environments = Environment.objects.filter(id__in=eids)
+                environments = list(Environment.objects.filter(id__in=eids))
                 environment_map = {env.id: env.name for env in environments}
 
         check_ins = MonitorCheckIn.objects.filter(

src/sentry/monitors/serializers.py

@@ -196,19 +196,19 @@ def get_attrs(self, item_list, user, **kwargs):
             for actor, serialized_actor in zip(filtered_actors, actors_serialized)
         }
 
-        monitor_environments = (
+        monitor_environments_qs = (
             MonitorEnvironment.objects.filter(monitor__in=item_list)
             .order_by("-last_checkin")
             .exclude(
                 status__in=[MonitorStatus.PENDING_DELETION, MonitorStatus.DELETION_IN_PROGRESS]
             )
         )
         if self.environments:
-            monitor_environments = monitor_environments.filter(
+            monitor_environments_qs = monitor_environments_qs.filter(
                 environment_id__in=[env.id for env in self.environments]
             )
 
-        monitor_environments = list(monitor_environments)
+        monitor_environments = list(monitor_environments_qs)
         serialized_monitor_environments = defaultdict(list)
         for monitor_env, serialized in zip(
             monitor_environments, serialize(monitor_environments, user)