fix: Extract Tornados cookies correctly, fix #276

Author: untitaker

sentry_sdk/integrations/tornado.py

@@ -165,7 +165,7 @@ def content_length(self):
 
     def cookies(self):
         # type: () -> Dict
-        return dict(self.request.cookies)
+        return {k: v.value for k, v in self.request.cookies.items()}
 
     def raw_data(self):
         # type: () -> bytes

tests/integrations/tornado/test_tornado.py

@@ -18,15 +18,17 @@ def get(self):
 class TestBasic(AsyncHTTPTestCase):
     @pytest.fixture(autouse=True)
     def initialize(self, sentry_init, capture_events):
-        sentry_init(integrations=[TornadoIntegration()])
+        sentry_init(integrations=[TornadoIntegration()], send_default_pii=True)
         self.events = capture_events()
 
     def get_app(self):
 
         return Application([(r"/hi", CrashingHandler)])
 
     def test_basic(self):
-        response = self.fetch("/hi?foo=bar")
+        response = self.fetch(
+            "/hi?foo=bar", headers={"Cookie": "name=value; name2=value2; name3=value3"}
+        )
         assert response.code == 500
 
         event, = self.events
@@ -37,7 +39,13 @@ def test_basic(self):
         host = request["headers"]["Host"]
         assert event["request"] == {
             "env": {"REMOTE_ADDR": "127.0.0.1"},
-            "headers": {"Accept-Encoding": "gzip", "Connection": "close", "Host": host},
+            "headers": {
+                "Accept-Encoding": "gzip",
+                "Connection": "close",
+                "Host": host,
+                "Cookie": "name=value; name2=value2; name3=value3",
+            },
+            "cookies": {"name": "value", "name2": "value2", "name3": "value3"},
             "method": "GET",
             "query_string": "foo=bar",
             "url": "http://{host}/hi".format(host=host),