From 8d9f4c5a5d9afa8139744a9bd074a35f1237e30c Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Thu, 5 Mar 2026 09:33:28 +0100 Subject: [PATCH 1/8] test(angular): Fix failing canary test --- .github/workflows/canary.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/canary.yml b/.github/workflows/canary.yml index 233bc748b112..b244941e5c8d 100644 --- a/.github/workflows/canary.yml +++ b/.github/workflows/canary.yml @@ -69,9 +69,9 @@ jobs: fail-fast: false matrix: include: - - test-application: 'angular-20' + - test-application: 'angular-21' build-command: 'test:build-canary' - label: 'angular-20 (next)' + label: 'angular-21 (next)' - test-application: 'create-react-app' build-command: 'test:build-canary' label: 'create-react-app (canary)' From bf617726c22bea81c56df80daa67d919880bfa89 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Thu, 5 Mar 2026 10:03:14 +0100 Subject: [PATCH 2/8] tmp change angular package.json to run test app --- packages/angular/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/angular/package.json b/packages/angular/package.json index c2d4b1168863..5777090db8b3 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -15,7 +15,7 @@ "access": "public" }, "peerDependencies": { - "@angular/common": ">= 14.x <= 21.x", + "@angular/common": ">= 14.x <= 22.x", "@angular/core": ">= 14.x <= 21.x", "@angular/router": ">= 14.x <= 21.x", "rxjs": "^6.5.5 || ^7.x" From 42dd371b1ebd4f9c0941423568c25d8691a93642 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Thu, 5 Mar 2026 12:55:07 +0100 Subject: [PATCH 3/8] force install? --- .../e2e-tests/test-applications/angular-21/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-packages/e2e-tests/test-applications/angular-21/package.json b/dev-packages/e2e-tests/test-applications/angular-21/package.json index f1e9f4d0e871..c921398b379b 100644 --- a/dev-packages/e2e-tests/test-applications/angular-21/package.json +++ b/dev-packages/e2e-tests/test-applications/angular-21/package.json @@ -10,7 +10,7 @@ "watch": "ng build --watch --configuration development", "test": "playwright test", "test:build": "pnpm install && pnpm build", - "test:build-canary": "pnpm install && pnpm add @angular/animations@next @angular/common@next @angular/compiler@next @angular/core@next @angular/forms@next @angular/platform-browser@next @angular/platform-browser-dynamic@next @angular/router@next && pnpm add -D @angular-devkit/build-angular@next @angular/cli@next @angular/compiler-cli@next && pnpm build", + "test:build-canary": "pnpm install && pnpm add @angular/animations@next @angular/common@next @angular/compiler@next @angular/core@next @angular/forms@next @angular/platform-browser@next @angular/platform-browser-dynamic@next @angular/router@next && pnpm add -D @angular-devkit/build-angular@next @angular/cli@next @angular/compiler-cli@next --force && pnpm build", "test:assert": "playwright test", "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist" }, From 37ef6f55df5ed77e58034b98d29b26aae909774b Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Thu, 5 Mar 2026 13:24:39 +0100 Subject: [PATCH 4/8] more force --- .../e2e-tests/test-applications/angular-21/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-packages/e2e-tests/test-applications/angular-21/package.json b/dev-packages/e2e-tests/test-applications/angular-21/package.json index c921398b379b..64841dd83392 100644 --- a/dev-packages/e2e-tests/test-applications/angular-21/package.json +++ b/dev-packages/e2e-tests/test-applications/angular-21/package.json @@ -10,7 +10,7 @@ "watch": "ng build --watch --configuration development", "test": "playwright test", "test:build": "pnpm install && pnpm build", - "test:build-canary": "pnpm install && pnpm add @angular/animations@next @angular/common@next @angular/compiler@next @angular/core@next @angular/forms@next @angular/platform-browser@next @angular/platform-browser-dynamic@next @angular/router@next && pnpm add -D @angular-devkit/build-angular@next @angular/cli@next @angular/compiler-cli@next --force && pnpm build", + "test:build-canary": "pnpm install --force && pnpm add --force @angular/animations@next @angular/common@next @angular/compiler@next @angular/core@next @angular/forms@next @angular/platform-browser@next @angular/platform-browser-dynamic@next @angular/router@next && pnpm add -D --force @angular-devkit/build-angular@next @angular/cli@next @angular/compiler-cli@next && pnpm build", "test:assert": "playwright test", "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist" }, From dcfeac7fffabe2d3b59d52072a4261c6c935b663 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 9 Mar 2026 13:57:10 +0100 Subject: [PATCH 5/8] bump to node 22 for angular-21 (?) --- .github/workflows/canary.yml | 1 - dev-packages/e2e-tests/test-applications/angular-21/package.json | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/canary.yml b/.github/workflows/canary.yml index b244941e5c8d..f9c74b5f344f 100644 --- a/.github/workflows/canary.yml +++ b/.github/workflows/canary.yml @@ -130,7 +130,6 @@ jobs: with: version: 9.15.9 - name: Set up Node - if: matrix.test-application != 'angular-20' uses: actions/setup-node@v6 with: node-version-file: 'dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}/package.json' diff --git a/dev-packages/e2e-tests/test-applications/angular-21/package.json b/dev-packages/e2e-tests/test-applications/angular-21/package.json index 64841dd83392..d6a2c807c1e7 100644 --- a/dev-packages/e2e-tests/test-applications/angular-21/package.json +++ b/dev-packages/e2e-tests/test-applications/angular-21/package.json @@ -47,6 +47,7 @@ "typescript": "~5.9.0" }, "volta": { + "node": "22.22.0", "extends": "../../package.json" }, "sentryTest": { From c5da1628202a79576040c425566872f1533907c6 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 9 Mar 2026 14:15:59 +0100 Subject: [PATCH 6/8] remove angular 20 canary test (in favour of ng21) --- .../e2e-tests/test-applications/angular-20/package.json | 9 --------- 1 file changed, 9 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/angular-20/package.json b/dev-packages/e2e-tests/test-applications/angular-20/package.json index 02a333094158..fbf27580ed67 100644 --- a/dev-packages/e2e-tests/test-applications/angular-20/package.json +++ b/dev-packages/e2e-tests/test-applications/angular-20/package.json @@ -10,7 +10,6 @@ "watch": "ng build --watch --configuration development", "test": "playwright test", "test:build": "pnpm install && pnpm build", - "test:build-canary": "pnpm install && pnpm add @angular/animations@next @angular/common@next @angular/compiler@next @angular/core@next @angular/forms@next @angular/platform-browser@next @angular/platform-browser-dynamic@next @angular/router@next && pnpm add -D @angular-devkit/build-angular@next @angular/cli@next @angular/compiler-cli@next && pnpm build", "test:assert": "playwright test", "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist" }, @@ -48,13 +47,5 @@ }, "volta": { "extends": "../../package.json" - }, - "sentryTest": { - "optionalVariants": [ - { - "build-command": "pnpm test:build-canary", - "label": "angular (canary)" - } - ] } } From cac143201348b0f7440b21aad20e3cce8943581c Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 9 Mar 2026 14:16:14 +0100 Subject: [PATCH 7/8] remove --force --- .../e2e-tests/test-applications/angular-21/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-packages/e2e-tests/test-applications/angular-21/package.json b/dev-packages/e2e-tests/test-applications/angular-21/package.json index d6a2c807c1e7..fddd7708d936 100644 --- a/dev-packages/e2e-tests/test-applications/angular-21/package.json +++ b/dev-packages/e2e-tests/test-applications/angular-21/package.json @@ -10,7 +10,7 @@ "watch": "ng build --watch --configuration development", "test": "playwright test", "test:build": "pnpm install && pnpm build", - "test:build-canary": "pnpm install --force && pnpm add --force @angular/animations@next @angular/common@next @angular/compiler@next @angular/core@next @angular/forms@next @angular/platform-browser@next @angular/platform-browser-dynamic@next @angular/router@next && pnpm add -D --force @angular-devkit/build-angular@next @angular/cli@next @angular/compiler-cli@next && pnpm build", + "test:build-canary": "pnpm install && pnpm add @angular/animations@next @angular/common@next @angular/compiler@next @angular/core@next @angular/forms@next @angular/platform-browser@next @angular/platform-browser-dynamic@next @angular/router@next && pnpm add -D @angular-devkit/build-angular@next @angular/cli@next @angular/compiler-cli@next && pnpm build", "test:assert": "playwright test", "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist" }, From 53f6beaa739593ae06759866b6c62fb67c25d7aa Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 9 Mar 2026 15:10:45 +0100 Subject: [PATCH 8/8] Reset angular package change --- packages/angular/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/angular/package.json b/packages/angular/package.json index 5777090db8b3..c2d4b1168863 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -15,7 +15,7 @@ "access": "public" }, "peerDependencies": { - "@angular/common": ">= 14.x <= 22.x", + "@angular/common": ">= 14.x <= 21.x", "@angular/core": ">= 14.x <= 21.x", "@angular/router": ">= 14.x <= 21.x", "rxjs": "^6.5.5 || ^7.x"