fix(tracing): Add missing attributes in vercel-ai spans #18333
+353
−217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
added a commit
that referenced
this pull request
Nov 26, 2025
isaacs
force-pushed
the
isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing
branch
from
e14c708 to
830aa2e
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
isaacs
added a commit
that referenced
this pull request
Nov 26, 2025
Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216
isaacs
force-pushed
the
isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing
branch
from
830aa2e to
f5b9b31
Compare
RulaKhaled
reviewed
Nov 27, 2025
Member
RulaKhaled
left a comment
RulaKhaled
left a comment
There was a problem hiding this comment.
The logic lgtm, I left some quick comments. We also need to a. update tests for Vercel v5 (it's a nested folder within vercel node integration tests) and b. run yarn fix in the root folder to fix lint issues
Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216
isaacs
force-pushed
the
isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing
branch
from
f5b9b31 to
346d3b3
Compare
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines
+129
to
+139
| } | ||
| const prompt = attributes[AI_PROMPT_ATTRIBUTE]; | ||
| if ( | ||
| typeof prompt === 'string' && | ||
| !attributes[GEN_AI_REQUEST_MESSAGES_ATTRIBUTE] && | ||
| !attributes[AI_PROMPT_MESSAGES_ATTRIBUTE] | ||
| ) { | ||
| const messages = convertPromptToMessages(prompt); | ||
| if (messages.length) span.setAttribute(GEN_AI_REQUEST_MESSAGES_ATTRIBUTE, getTruncatedJsonString(messages)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: The createRunner() function call is missing an await keyword, causing runner to be a Promise.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
If createRunner() returns a Promise, then runner without await would be a Promise object, not the resolved value. Calling .expect() directly on a Promise object would result in a runtime error similar to 'TypeError: runner.expect is not a function' because Promises do not have an .expect() method. This causes the integration test to fail at runtime when executed, preventing verification of Vercel AI span attributes.
💡 Suggested Fix
Add the await keyword before the createRunner() call: const runner = await createRunner().
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/core/src/tracing/vercel-ai/utils.ts#L93-L139
Potential issue: If `createRunner()` returns a Promise, then `runner` without `await`
would be a Promise object, not the resolved value. Calling `.expect()` directly on a
Promise object would result in a runtime error similar to 'TypeError: runner.expect is
not a function' because Promises do not have an `.expect()` method. This causes the
integration test to fail at runtime when executed, preventing verification of Vercel AI
span attributes.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 4693704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JS-1216
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).