Skip to content

Improve RPM name generated by CPack #604

@BugelNiels

Description

@BugelNiels

Currently, when building an RPM of reflectcpp with CPack, the resulting name will look something like this:

reflectcpp-0.23.0-Linux.rpm

However, this is missing some information from the file name (such as el9 and x86_64).

For Debian packages, The CMakeLists.txt already sets the following:

set(CPACK_DEBIAN_FILE_NAME DEB-DEFAULT)

I would propose to also add the following under the RPM-specific configuration:

set(CPACK_RPM_FILE_NAME RPM-DEFAULT)
# This is not strictly necessary, but good for completeness
set(CPACK_RPM_PACKAGE_LICENSE "MIT")

I tested it and it would generate a file name like this:

reflectcpp-0.23.0-1.el9.x86_64.rpm

Let me know if this is okay; if so I can create the PR.


Another slightly unrelated question, the repo is called reflect-cpp, but the resulting packages generated from CMake are called reflectcpp. Is there any particular reason why this does not include the hyphen?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions