Skip to content

Commit 17a1fdb

Browse files
authored
Catch EDR AttributeError errors more fine grained (#2118)
* fix EDR error handling * test commit * use is None and remove detail from error * change wording * make it on one linegs * remove typing * remove import
1 parent ec1eb38 commit 17a1fdb

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

pygeoapi/provider/base_edr.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929

3030
import logging
3131

32-
from pygeoapi.provider.base import BaseProvider, ProviderInvalidDataError
32+
from pygeoapi.provider.base import (BaseProvider, ProviderInvalidDataError,
33+
ProviderQueryError)
3334

3435
LOGGER = logging.getLogger(__name__)
3536

@@ -116,8 +117,12 @@ def query(self, **kwargs):
116117
117118
:returns: coverage data as `dict` of CoverageJSON or native format
118119
"""
119-
120+
query_type = kwargs.get('query_type')
121+
if query_type is None:
122+
raise ProviderQueryError('Query type is required')
120123
try:
121-
return getattr(self, kwargs.get('query_type'))(**kwargs)
124+
query_function = getattr(self, query_type)
122125
except AttributeError:
123-
raise NotImplementedError('Query not implemented!')
126+
raise ProviderQueryError('Query type not implemented')
127+
128+
return query_function(**kwargs)

0 commit comments

Comments
 (0)