Removed GetLimit (#736)

Author: Nyholm

CHANGELOG.md

@@ -11,6 +11,9 @@ The change log describes what is "Added", "Removed", "Changed" or "Fixed" betwee
 ### Changed
 
 - `ProvierAggregator::getProvider` is now private
+- `ProvierAggregator::limit` was removed
+- `ProvierAggregator::getLimit` was removed
+- `ProvierAggregator::__constructor` changed the order of the parameters. 
 
 ## 4.0.0 - Beta 2
 

ProviderAggregator.php

@@ -46,11 +46,12 @@ class ProviderAggregator implements Geocoder
     private $decider;
 
     /**
-     * @param int $limit
+     * @param callable|null $decider
+     * @param int           $limit
      */
-    public function __construct(int $limit = Geocoder::DEFAULT_RESULT_LIMIT, callable $decider = null)
+    public function __construct(callable $decider = null, int $limit = Geocoder::DEFAULT_RESULT_LIMIT)
     {
-        $this->limit($limit);
+        $this->limit = $limit;
         $this->decider = $decider ?? __CLASS__.'::getProvider';
     }
 
@@ -104,26 +105,6 @@ public function reverse(float $latitude, float $longitude): Collection
             ->withLimit($this->limit));
     }
 
-    /**
-     * @param $limit
-     *
-     * @return $this
-     */
-    public function limit(int $limit): self
-    {
-        $this->limit = $limit;
-
-        return $this;
-    }
-
-    /**
-     * @return int
-     */
-    public function getLimit(): int
-    {
-        return $this->limit;
-    }
-
     /**
      * Registers a new provider to the aggregator.
      *

Tests/ProviderAggregatorTest.php

@@ -138,11 +138,6 @@ public function testGetProviderWithMultipleProvidersReturnsTheFirstOne()
         $this->assertSame($provider1, NSA::invokeMethod($this->geocoder, 'getProvider', $query, $providers, null));
         $this->assertSame($provider2, NSA::invokeMethod($this->geocoder, 'getProvider', $query, $providers, $provider2));
     }
-
-    public function testDefaultMaxResults()
-    {
-        $this->assertSame(Geocoder::DEFAULT_RESULT_LIMIT, $this->geocoder->getLimit());
-    }
 }
 
 class MockProvider implements Provider