Commit 3bb209c
authored
Use JupyterIntegration API (#191)
As a suggestion from
Kotlin/kotlin-jupyter-libraries#358 (comment),
move the imports from the library JSON descriptor to the library itself.
Also add basic tests on the integration.
This change makes the descriptor more flexible. Currently, with imports
in JSON, if a new import is ever added to the descriptor,
```diff
{
"description": "A library to use the Develocity API in Kotlin scripts or projects",
"properties": [
- { "name": "version", "value": "2024.1.0" },
+ { "name": "version", "value": "2024.2.0" },
...
"imports": [
"com.gabrielfeo.develocity.api.*",
"com.gabrielfeo.develocity.api.model.*",
"com.gabrielfeo.develocity.api.extension.*",
+ "com.gabrielfeo.develocity.api.new.*"
]
}
```
using it with a past version, which didn't yet contain the new package,
would break:
```
%use develocity-api-kotlin(2024.1.0)
\_ now fails with "Unresolved reference" if using the latest descriptor
```1 parent 963df39 commit 3bb209c
File tree
4 files changed
+68
-0
lines changed- library
- src
- integrationTest/kotlin/com/gabrielfeo/develocity/api/internal/jupyter
- main/kotlin/com/gabrielfeo/develocity/api/internal/jupyter
4 files changed
+68
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
47 | 48 | | |
48 | 49 | | |
49 | 50 | | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
50 | 57 | | |
51 | 58 | | |
52 | 59 | | |
| |||
80 | 87 | | |
81 | 88 | | |
82 | 89 | | |
| 90 | + | |
83 | 91 | | |
84 | 92 | | |
85 | 93 | | |
| |||
Lines changed: 46 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
0 commit comments