fix: #19 fix error guard and mapResponse method

Author: sodiqit-fsd

api/src/core/controller.core.ts

@@ -69,14 +69,14 @@ export const getRequestUser = (data: unknown, ctx: ExecutionContext) => {
 };
 export const User = createParamDecorator(getRequestUser);
 
-export function mapResponse<T, EI extends BaseError<unknown>, EO>(data: T | EI) {
+export function mapResponse<T, EI, EO>(data: T | BaseError<EI>) {
     return async (
-        onData: (data: Exclude<T, EI>) => ControllerResponse | Promise<ControllerResponse>,
-        onError?: (e: EI) => BaseError<EO> | Promise<BaseError<EO>>,
+        onData: (data: T) => ControllerResponse | Promise<ControllerResponse>,
+        onError?: (e: BaseError<EI>) => BaseError<EO> | Promise<BaseError<EO>>,
     ) =>
         isError(data)
             ? onError
                 ? Promise.resolve(onError(data))
                 : Promise.resolve(data)
-            : Promise.resolve(onData(data as Exclude<T, EI>));
+            : Promise.resolve(onData(data));
 }

api/src/core/errors.core.ts

@@ -40,7 +40,7 @@ export class BaseError<E> {
     }
 }
 
-export function isError<T, E>(value: T | BaseError<E>): value is BaseError<E> {
+export function isError<T, E, BE extends BaseError<E>>(value: T | BE): value is BE {
     return value instanceof BaseError;
 }