@@ -2,7 +2,6 @@ import { BaseError } from '../errors.core';
22import { createMock , DeepMocked } from '@golevelup/ts-jest' ;
33import { DatabaseServiceProvider } from '../../services/database/database.service' ;
44import { HttpInterceptor } from '../interceptor.core' ;
5- import { Logger , LoggerProvider } from '../logger.core' ;
65import { ModuleRef } from '@nestjs/core' ;
76import { Controller , Get } from '@nestjs/common' ;
87import { ErrorHandleMiddlewareProvider } from '../errorHandleMiddleware.core' ;
@@ -28,7 +27,6 @@ describe('Interceptor', () => {
2827 const appWrap = { } as AppWrap ;
2928
3029 let interceptor : HttpInterceptor ;
31- let logger : DeepMocked < LoggerProvider > ;
3230 let moduleRef : DeepMocked < ModuleRef > ;
3331 let db : {
3432 Prisma : DeepMocked < DatabaseServiceProvider [ 'Prisma' ] > ;
@@ -52,23 +50,17 @@ describe('Interceptor', () => {
5250 } ,
5351 } ,
5452 } ,
55- {
56- provide : LoggerProvider ,
57- useValue : createMock < Logger > ( ) ,
58- } ,
5953 ] ,
6054 controllers : [ TestController ] ,
6155 } ) . compile ( ) ;
6256
6357 moduleRef = createMock < ModuleRef > ( ) ;
6458
6559 db = module . get ( DatabaseServiceProvider ) ;
66- logger = module . get ( LoggerProvider ) ;
6760
6861 interceptor = new HttpInterceptor (
6962 moduleRef ,
7063 db as unknown as DatabaseServiceProvider ,
71- logger ,
7264 ) ;
7365 appWrap . app = module . createNestApplication ( ) ;
7466 appWrap . app . useGlobalInterceptors ( interceptor ) ;
@@ -80,7 +72,6 @@ describe('Interceptor', () => {
8072
8173 afterEach ( ( ) => {
8274 moduleRef . resolve . mockClear ( ) ;
83- logger . log . mockClear ( ) ;
8475 testResponse . response . mockClear ( ) ;
8576 } ) ;
8677
@@ -203,29 +194,14 @@ describe('Interceptor', () => {
203194 describe ( 'onModuleInit and errorHandleMiddleware' , ( ) => {
204195 const errorHandleMiddleware = createMock < ErrorHandleMiddlewareProvider > ( ) ;
205196
206- it ( 'should log a message if error handler not provided' , async ( ) => {
207- moduleRef . resolve . mockResolvedValueOnce ( null ) ;
208-
209- await interceptor . onModuleInit ( ) ;
210-
211- expect ( moduleRef . resolve ) . toBeCalledTimes ( 1 ) ;
212- expect ( logger . log ) . toBeCalledTimes ( 1 ) ;
213- expect ( logger . log ) . toBeCalledWith ( 'No error handler where provided' ) ;
214- } ) ;
215-
216- it ( 'no logs on successful resolve ErrorHandleMiddlewareProvider' , async ( ) => {
217- moduleRef . resolve . mockResolvedValueOnce ( errorHandleMiddleware ) ;
218-
219- await interceptor . onModuleInit ( ) ;
220-
221- expect ( moduleRef . resolve ) . toBeCalledTimes ( 1 ) ;
222- expect ( logger . log ) . toBeCalledTimes ( 0 ) ;
223- } ) ;
224197
225198 it ( 'errorHandleMiddleware should be called' , async ( ) => {
199+ moduleRef . resolve . mockResolvedValueOnce ( errorHandleMiddleware ) ;
226200 testResponse . response . mockImplementationOnce ( ( ) => {
227201 throw 'Test error' ;
228202 } ) ;
203+
204+ await interceptor . onModuleInit ( ) ;
229205 await request ( appWrap . app . getHttpServer ( ) ) . get ( '/test/request' ) . send ( ) ;
230206
231207 expect ( errorHandleMiddleware . handleError ) . toBeCalledTimes ( 1 ) ;
0 commit comments