Skip to content

Commit 36341db

Browse files
committed
Merge branch 'main' of work.github.com:fullstack-development/nestjs-starter-kit into 20-paginate
2 parents 9e3bba4 + c4a9a73 commit 36341db

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

api/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
"@medibloc/nestjs-request-context": "^1.0.0",
2929
"@nestjs/common": "^9.0.0",
3030
"@nestjs/core": "^9.0.0",
31+
"@nestjs/jwt": "^9.0.0",
32+
"@nestjs/passport": "^9.0.0",
3133
"@nestjs/platform-express": "^9.0.0",
3234
"@nestjs/schedule": "^2.1.0",
3335
"@prisma/client": "^3.14.0",
@@ -41,6 +43,7 @@
4143
"express": "^4.17.2",
4244
"node-fetch": "^2.6.7",
4345
"passport": "^0.4.1",
46+
"passport-jwt": "^4.0.0",
4447
"prisma": "^3.14.0",
4548
"ramda": "^0.27.1",
4649
"reflect-metadata": "^0.1.13",
@@ -53,8 +56,6 @@
5356
"devDependencies": {
5457
"@golevelup/ts-jest": "^0.3.2",
5558
"@nestjs/cli": "^9.0.0",
56-
"@nestjs/jwt": "^9.0.0",
57-
"@nestjs/passport": "^9.0.0",
5859
"@nestjs/schematics": "^9.0.0",
5960
"@nestjs/testing": "^9.0.0",
6061
"@types/cookie-parser": "^1.4.2",
@@ -75,7 +76,6 @@
7576
"eslint-plugin-deprecation": "^1.2.0",
7677
"eslint-plugin-prettier": "^4.0.0",
7778
"jest": "28.1.3",
78-
"passport-jwt": "^4.0.0",
7979
"prettier": "^2.3.2",
8080
"source-map-support": "^0.5.20",
8181
"supertest": "^6.1.3",

api/src/core/controller.core.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,14 @@ export const getRequestUser = (data: unknown, ctx: ExecutionContext) => {
6969
};
7070
export const User = createParamDecorator(getRequestUser);
7171

72-
export function mapResponse<T, EI extends BaseError<unknown>, EO>(data: T | EI) {
72+
export function mapResponse<T, EI, EO>(data: T | BaseError<EI>) {
7373
return async (
74-
onData: (data: Exclude<T, EI>) => ControllerResponse | Promise<ControllerResponse>,
75-
onError?: (e: EI) => BaseError<EO> | Promise<BaseError<EO>>,
74+
onData: (data: T) => ControllerResponse | Promise<ControllerResponse>,
75+
onError?: (e: BaseError<EI>) => BaseError<EO> | Promise<BaseError<EO>>,
7676
) =>
7777
isError(data)
7878
? onError
7979
? Promise.resolve(onError(data))
8080
: Promise.resolve(data)
81-
: Promise.resolve(onData(data as Exclude<T, EI>));
81+
: Promise.resolve(onData(data));
8282
}

api/src/core/errors.core.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class BaseError<E> {
4040
}
4141
}
4242

43-
export function isError<T, E>(value: T | BaseError<E>): value is BaseError<E> {
43+
export function isError<T, E, BE extends BaseError<E>>(value: T | BE): value is BE {
4444
return value instanceof BaseError;
4545
}
4646

0 commit comments

Comments
 (0)