add test and prospecttive fix for missing framework versions

Author: baronfel

fcs/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj

@@ -66,6 +66,9 @@
     <Compile Include="$(FSharpSourcesRoot)\..\tests\service\TreeVisitorTests.fs">
       <Link>TreeVisitorTests.fs</Link>
     </Compile>
+    <Compile Include="$(FSharpSourcesRoot)\..\tests\service\ScriptOptionsTests.fs">
+      <Link>ScriptOptionsTests.fs</Link>
+    </Compile>
     <Compile Include="$(FSharpSourcesRoot)\..\tests\service\Program.fs" Condition="'$(TargetFramework)' == 'netcoreapp3.0'">
       <Link>Program.fs</Link>
     </Compile>

fcs/FSharp.Compiler.Service.Tests/FsxCompletionProviderTests.fs

@@ -23,7 +23,7 @@ namespace Microsoft.VisualStudio.FSharp.Editor.Tests.Roslyn
 open System
 open System.Collections.Generic
 open System.IO
-open System.Linq
+open System.Linq    
 open System.Reflection
 
 open NUnit.Framework

src/fsharp/DotNetFrameworkDependencies.fs

@@ -115,13 +115,19 @@ module internal FSharp.Compiler.DotNetFrameworkDependencies
         let desktopProductVersionMonikers = [|
             // major, minor, build, revision, moniker
                4,     8,      3815,     0,    "net48"
+               4,     8,      3761,     0,    "net48"
                4,     7,      3190,     0,    "net472"
+               4,     7,      3062,     0,    "net472"
                4,     7,      2600,     0,    "net471"
+               4,     7,      2558,     0,    "net471"
                4,     7,      2053,     0,    "net47"
+               4,     7,      2046,     0,    "net47"
                4,     6,      1590,     0,    "net462"
+               4,     6,        57,     0,    "net462"
                4,     6,      1055,     0,    "net461"
                4,     6,        81,     0,    "net46"
                4,     0,     30319, 34209,    "net452"
+               4,     0,     30319, 17020,    "net452"
                4,     0,     30319, 18408,    "net451"
                4,     0,     30319, 17929,    "net45"
                4,     0,     30319,     1,    "net4"
@@ -138,14 +144,16 @@ module internal FSharp.Compiler.DotNetFrameworkDependencies
             with _ -> defaultMscorlibVersion
 
         // Get the ProductVersion of this framework compare with table yield compatible monikers
-        let _, _, _, _, moniker =
+        match
             desktopProductVersionMonikers
-            |> Array.find (fun (major, minor, build, revision, _) ->
+            |> Array.tryFind (fun (major, minor, build, revision, _) ->
                 (majorPart >= major) &&
                 (minorPart >= minor) &&
                 (buildPart >= build) &&
-                (privatePart >= revision))
-        moniker
+                (privatePart >= revision)) with
+        | Some (_,_,_,_,moniker) -> moniker
+        | None -> // if no moniker can be found, assume latest stable?
+                  "net48"
 
     /// Gets the tfm E.g netcore3.0, net472
     let executionTfm =

tests/service/ScriptOptionsTests.fs

@@ -0,0 +1,35 @@
+#if INTERACTIVE
+#r "../../artifacts/bin/fcs/net461/FSharp.Compiler.Service.dll" // note, build FSharp.Compiler.Service.Tests.fsproj to generate this, this DLL has a public API so can be used from F# Interactive
+#r "../../artifacts/bin/fcs/net461/nunit.framework.dll"
+#load "FsUnit.fs"
+#load "Common.fs"
+#else
+module Tests.Service.ScriptOptions
+#endif
+
+open NUnit.Framework
+open FsUnit
+open System
+open FSharp.Compiler
+open FSharp.Compiler.SourceCodeServices
+open FSharp.Compiler.Service.Tests.Common
+
+
+let scriptSource = """
+open System
+let pi = Math.PI
+"""
+
+[<TestCase(true, false, [| "--targetprofile:mscorlib" |])>]
+[<TestCase(false, true, [| "--targetprofile:mscorlib" |])>]
+[<Test>]
+let ``can generate options for different frameworks regardless of execution environment``(assumeNetFx, useSdk, flags) =
+    let path = IO.Path.GetTempPath()
+    let file = IO.Path.GetTempFileName()
+    let tempFile = IO.Path.Combine(path, file)
+    let (options, errors) = 
+        checker.GetProjectOptionsFromScript(tempFile, Text.SourceText.ofString scriptSource, assumeDotNetFramework = assumeNetFx, useSdkRefs = useSdk, otherFlags = flags)
+        |> Async.RunSynchronously
+    match errors with
+    | [] -> ()
+    | errors -> failwithf "Error while parsing script with assumeDotNetFramework:%b, useSdkRefs:%b, and otherFlags:%A:\n%A" assumeNetFx useSdk flags errors