Skip to content

Commit d6cb35d

Browse files
authored
Re-enable some of the VS ide unit tests (#5165)
1 parent 08c0f88 commit d6cb35d

File tree

3 files changed

+19
-5
lines changed

3 files changed

+19
-5
lines changed

build.cmd

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -486,9 +486,6 @@ if NOT EXIST Proto\net40\bin\fsc.exe (
486486
set BUILD_PROTO=1
487487
)
488488

489-
rem turn off vs ide unit tests until they pass again
490-
set TEST_VS_IDEUNIT_SUITE= 0
491-
492489
rem
493490
rem This stops the dotnet cli from hunting around and
494491
rem finding the highest possible dotnet sdk version to use.

vsintegration/tests/UnitTests/Tests.Build.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,8 @@ type Build() =
179179
let cmd = tool.InternalGenerateResponseFileCommands()
180180
printfn "cmd=\"%s\"" cmd
181181
AssertEqual ("--optimize+" + Environment.NewLine +
182-
"--warnaserror-:52,109" + Environment.NewLine +
183182
"--warnaserror:76" + Environment.NewLine +
183+
"--warnaserror-:52,109" + Environment.NewLine +
184184
"--fullpaths" + Environment.NewLine +
185185
"--flaterrors" + Environment.NewLine +
186186
"--highentropyva-" + Environment.NewLine)

vsintegration/tests/UnitTests/VisualFSharp.UnitTests.fsproj

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,14 @@
2424
</Compile>
2525
<Compile Include="TestLib.Utils.fs" />
2626
<Compile Include="TestLib.Salsa.fs" />
27+
<!-- TODO: Fix this test
2728
<Compile Include="TestLib.LanguageService.fs" />
2829
<Compile Include="TestLib.ProjectSystem.fs" />
29-
<Compile Include="Tests.InternalCollections.fs" />
30+
--> <Compile Include="Tests.InternalCollections.fs" />
3031
<Compile Include="Tests.Build.fs" />
3132
<Compile Include="Tests.TaskReporter.fs" />
3233
<Compile Include="Tests.Watson.fs" />
34+
<!-- TODO: Fix this test
3335
<Compile Include="Tests.XmlDocComments.fs" />
3436
<Compile Include="LegacyLanguageService\Tests.LanguageService.General.fs" />
3537
<Compile Include="LegacyLanguageService\Tests.LanguageService.Completion.fs" />
@@ -51,6 +53,7 @@
5153
<Compile Include="LegacyProjectSystem\Tests.ProjectSystem.References.fs" />
5254
<Compile Include="LegacyProjectSystem\Tests.ProjectSystem.RoundTrip.fs" />
5355
<Compile Include="LegacyProjectSystem\Tests.ProjectSystem.UpToDate.fs" />
56+
-->
5457
<Compile Include="..\..\..\tests\service\FsUnit.fs">
5558
<Link>CompilerService\FsUnit.fs</Link>
5659
</Compile>
@@ -81,27 +84,34 @@
8184
<Compile Include="..\..\..\tests\service\ExprTests.fs">
8285
<Link>CompilerService\ExprTests.fs</Link>
8386
</Compile>
87+
<!-- TODO: Fix this test
8488
<Compile Include="..\..\..\tests\service\CSharpProjectAnalysis.fs">
8589
<Link>CompilerService\CSharpProjectAnalysis.fs</Link>
8690
</Compile>
91+
-->
8792
<Compile Include="..\..\..\tests\service\ProjectOptionsTests.fs">
8893
<Link>CompilerService\ProjectOptionsTests.fs</Link>
8994
</Compile>
9095
<Compile Include="..\..\..\tests\service\StructureTests.fs">
9196
<Link>CompilerService\StructureTests.fs</Link>
9297
</Compile>
98+
<!-- TODO: Fix this test
9399
<Compile Include="..\..\..\tests\service\AssemblyContentProviderTests.fs">
94100
<Link>CompilerService\AssemblyContentProviderTests.fs</Link>
95101
</Compile>
102+
-->
96103
<Compile Include="..\..\..\tests\service\ServiceUntypedParseTests.fs">
97104
<Link>CompilerService\ServiceUntypedParseTests.fs</Link>
98105
</Compile>
106+
<!-- TODO: Fix this test
99107
<Compile Include="UnusedOpensTests.fs">
100108
<Link>CompilerService\UnusedOpensTests.fs</Link>
101109
</Compile>
110+
-->
102111
<Compile Include="SyntacticColorizationServiceTests.fs">
103112
<Link>Roslyn\SyntacticColorizationServiceTests.fs</Link>
104113
</Compile>
114+
<!-- TODO: Fix this test
105115
<Compile Include="SemanticColorizationServiceTests.fs">
106116
<Link>Roslyn\SemanticColorizationServiceTests.fs</Link>
107117
</Compile>
@@ -111,24 +121,30 @@
111121
<Compile Include="HelpContextServiceTests.fs">
112122
<Link>Roslyn\HelpContextServiceTests.fs</Link>
113123
</Compile>
124+
-->
114125
<Compile Include="EditorFormattingServiceTests.fs">
115126
<Link>Roslyn\EditorFormattingServiceTests.fs</Link>
116127
</Compile>
128+
<!-- TODO: Fix this test
117129
<Compile Include="IndentationServiceTests.fs">
118130
<Link>Roslyn\IndentationServiceTests.fs</Link>
119131
</Compile>
120132
<Compile Include="BreakpointResolutionService.fs">
121133
<Link>Roslyn\BreakpointResolutionService.fs</Link>
122134
</Compile>
135+
-->
123136
<Compile Include="LanguageDebugInfoServiceTests.fs">
124137
<Link>Roslyn\LanguageDebugInfoServiceTests.fs</Link>
125138
</Compile>
139+
<!-- TODO: Fix this test
126140
<Compile Include="DocumentDiagnosticAnalyzerTests.fs">
127141
<Link>Roslyn\DocumentDiagnosticAnalyzerTests.fs</Link>
128142
</Compile>
143+
-->
129144
<Compile Include="ProjectDiagnosticAnalyzerTests.fs">
130145
<Link>Roslyn\ProjectDiagnosticAnalyzerTests.fs</Link>
131146
</Compile>
147+
<!-- TODO: Fix this test
132148
<Compile Include="CompletionProviderTests.fs">
133149
<Link>Roslyn\CompletionProviderTests.fs</Link>
134150
</Compile>
@@ -144,6 +160,7 @@
144160
<Compile Include="DocumentHighlightsServiceTests.fs">
145161
<Link>Roslyn\DocumentHighlightsServiceTests.fs</Link>
146162
</Compile>
163+
-->
147164
<None Include="VisualFSharp.UnitTests.dll.config" CopyToOutputDirectory="PreserveNewest" />
148165
<None Include="app.runsettings" />
149166
</ItemGroup>

0 commit comments

Comments
 (0)