add to signature file

Author: dsyme

docs/content/queue.fsx

@@ -11,7 +11,7 @@ sequentially and in order.
 
 The thread processing these requests can also run a low-priority, interleaved background operation when the
 queue is empty.  This can be used to implicitly bring the background check of a project "up-to-date".  
-When the operations queue has been empty for 1 second , 
+When the operations queue has been empty for 2 seconds,
 this background work is run in small incremental fragments. This work is cooperatively time-sliced to be approximately <50ms, (see `maxTimeShareMilliseconds` in 
 IncrementalBuild.fs). The project to be checked in the background is set implicitly 
 by calls to ``CheckFileInProject`` and ``ParseAndCheckFileInProject``.

src/fsharp/fsc.fs

@@ -615,15 +615,15 @@ type ILResource with
         | ILResourceLocation.Local b -> b()
         | _-> error(InternalError("Bytes",rangeStartup))
 
-let EncodeInterfaceData(tcConfig:TcConfig,tcGlobals,exportRemapping,generatedCcu,outfile) = 
+let EncodeInterfaceData(tcConfig:TcConfig,tcGlobals,exportRemapping,generatedCcu,outfile,isIncrementalBuild) = 
       if GenerateInterfaceData(tcConfig) then 
         if verbose then dprintfn "Generating interface data attribute...";
         let resource = WriteSignatureData (tcConfig,tcGlobals,exportRemapping,generatedCcu,outfile)
         if verbose then dprintf "Generated interface data attribute!\n";
         // REVIEW: need a better test for this
         let outFileNoExtension = Filename.chopExtension outfile
         let isCompilerServiceDll = outFileNoExtension.Contains("FSharp.LanguageService.Compiler")
-        if tcConfig.useOptimizationDataFile || tcGlobals.compilingFslib || isCompilerServiceDll then 
+        if (tcConfig.useOptimizationDataFile || tcGlobals.compilingFslib || isCompilerServiceDll) && not isIncrementalBuild then 
             let sigDataFileName = (Filename.chopExtension outfile)+".sigdata"
             File.WriteAllBytes(sigDataFileName,resource.Bytes);
         let sigAttr = mkSignatureDataVersionAttr tcGlobals (IL.parseILVersion Internal.Utilities.FSharpEnvironment.FSharpBinaryMetadataFormatRevision) 
@@ -1917,7 +1917,7 @@ let main2(Args(tcConfig, tcImports, frameworkTcImports: TcImports, tcGlobals, er
 
     let sigDataAttributes,sigDataResources = 
       try
-        EncodeInterfaceData(tcConfig, tcGlobals, exportRemapping, generatedCcu, outfile)
+        EncodeInterfaceData(tcConfig, tcGlobals, exportRemapping, generatedCcu, outfile, false)
       with e -> 
         errorRecoveryNoRange e
         SqmLoggerWithConfig tcConfig errorLogger.ErrorNumbers errorLogger.WarningNumbers

src/fsharp/fsc.fsi

@@ -21,7 +21,7 @@ type ErrorLoggerProvider =
 
 type SigningInfo = SigningInfo of (* delaysign:*) bool * (*signer:*)  string option * (*container:*) string option
 
-val EncodeInterfaceData: tcConfig:TcConfig * tcGlobals:TcGlobals * exportRemapping:Tastops.Remap * generatedCcu: Tast.CcuThunk * outfile: string -> ILAttribute list * ILResource list
+val EncodeInterfaceData: tcConfig:TcConfig * tcGlobals:TcGlobals * exportRemapping:Tastops.Remap * generatedCcu: Tast.CcuThunk * outfile: string * isIncrementalBuild: bool -> ILAttribute list * ILResource list
 val ValidateKeySigningAttributes : tcConfig:TcConfig * tcGlobals:TcGlobals * TypeChecker.TopAttribs -> SigningInfo
 val GetSigner : SigningInfo -> ILBinaryWriter.ILStrongNameSigner option
 

src/fsharp/vs/IncrementalBuild.fs

@@ -1500,7 +1500,7 @@ module internal IncrementalFSharpBuild =
                         let exportRemapping = MakeExportRemapping generatedCcu generatedCcu.Contents
 
                         let sigData = 
-                            let _sigDataAttributes,sigDataResources = Driver.EncodeInterfaceData(tcConfig,tcGlobals,exportRemapping,generatedCcu,outfile)
+                            let _sigDataAttributes,sigDataResources = Driver.EncodeInterfaceData(tcConfig,tcGlobals,exportRemapping,generatedCcu,outfile,true)
                             [ for r in sigDataResources  do
                                 let ccuName = GetSignatureDataResourceName r
                                 let bytes = 

src/fsharp/vs/Reactor.fs

@@ -31,7 +31,7 @@ module internal Reactor =
      /// are open. 
      type Reactor() = 
         static let GetEnvInteger e dflt = match System.Environment.GetEnvironmentVariable(e) with null -> dflt | t -> try int t with _ -> dflt
-        static let pauseBeforeBackgroundWorkDefault = GetEnvInteger "FCS_PauseBeforeBackgroundWorkMilliseconds" 1000
+        static let pauseBeforeBackgroundWorkDefault = GetEnvInteger "FCS_PauseBeforeBackgroundWorkMilliseconds" 2000
         let mutable pauseBeforeBackgroundWork = pauseBeforeBackgroundWorkDefault
 
         // We need to store the culture for the VS thread that is executing now,

src/fsharp/vs/service.fs

@@ -2659,7 +2659,6 @@ type BackgroundCompiler(projectCacheSize, keepAssemblyContents, keepAllBackgroun
 
     member __.FrameworkImportsCache = frameworkTcImportsCache
     member __.ImplicitlyStartBackgroundWork with get() = implicitlyStartBackgroundWork and set v = implicitlyStartBackgroundWork <- v
-    member __.PauseBeforeBackgroundWork with get() = Reactor.Reactor().PauseBeforeBackgroundWork and set v = Reactor.Reactor().PauseBeforeBackgroundWork <- v
     static member GlobalForegroundParseCountStatistic = foregroundParseCount
     static member GlobalForegroundTypeCheckCountStatistic = foregroundTypeCheckCount
 
@@ -3196,6 +3195,7 @@ type FSharpChecker(projectCacheSize, keepAssemblyContents, keepAllBackgroundReso
     member ic.FileChecked  = backgroundCompiler.FileChecked
     member ic.ProjectChecked = backgroundCompiler.ProjectChecked
     member ic.ImplicitlyStartBackgroundWork with get() = backgroundCompiler.ImplicitlyStartBackgroundWork and set v = backgroundCompiler.ImplicitlyStartBackgroundWork <- v
+    member ic.PauseBeforeBackgroundWork with get() = Reactor.Reactor().PauseBeforeBackgroundWork and set v = Reactor.Reactor().PauseBeforeBackgroundWork <- v
 
     static member GlobalForegroundParseCountStatistic = BackgroundCompiler.GlobalForegroundParseCountStatistic
     static member GlobalForegroundTypeCheckCountStatistic = BackgroundCompiler.GlobalForegroundTypeCheckCountStatistic

src/fsharp/vs/service.fsi

@@ -626,9 +626,12 @@ type FSharpChecker =
     /// For example, dependent references may have been deleted or created.
     member InvalidateConfiguration: options: FSharpProjectOptions -> unit    
 
-    /// Begin background parsing the given project.
+    [<Obsolete("This method has been renamed to CheckProjectInBackground")>]
     member StartBackgroundCompile: options: FSharpProjectOptions -> unit
 
+    /// Set the project to be checked in the background.  Overrides any previous call to <c>CheckProjectInBackground</c>
+    member CheckProjectInBackground: options: FSharpProjectOptions -> unit
+
     /// Stop the background compile.
     [<Obsolete("Explicitly stopping background compilation is not recommended and the functionality to allow this may be rearchitected in future release.  If you use this functionality please add an issue on http://github.com/fsharp/FSharp.Compiler.Service describing how you use it and ignore this warning.")>]
     member StopBackgroundCompile : unit -> unit
@@ -676,11 +679,16 @@ type FSharpChecker =
     /// A maximum number of megabytes of allocated memory. If the figure reported by <c>System.GC.GetTotalMemory(false)</c> goes over this limit, the FSharpChecker object will attempt to free memory and reduce cache sizes to a minimum.</param>
     member MaxMemory : int with get, set
     
-    /// If true, then calls to CheckFileInProject implicitly start a background check of that project, replacing
+    /// Get or set a flag which controls if background work is started implicitly. 
+    ///
+    /// If true, calls to CheckFileInProject implicitly start a background check of that project, replacing
     /// any other background checks in progress. This is useful in IDE applications with spare CPU cycles as 
     /// it prepares the project analysis results for use.  The default is 'true'.
     member ImplicitlyStartBackgroundWork: bool with get, set
     
+    /// Get or set the pause time in milliseconds before background work is started.
+    member PauseBeforeBackgroundWork: bool with get, set
+    
     [<Obsolete("Renamed to BeforeBackgroundFileCheck")>]
     member FileTypeCheckStateIsDirty : IEvent<string>