Do not check assembly symbols equality by DefinitionRange and name (#4662)

* Do not check assembly symbols equality by DefinitionRange and name

Assembly symbols have startup definition range and considered equal.
Fixes #4658.

* Add test for equality of entities from assemblies with the same name

* Add checks for range0 and rangeCmdArgs ranges

* Do not run new tests on netcoreapp2.0

Author: auduchinok

src/fsharp/NameResolution.fs

@@ -1346,19 +1346,23 @@ let tyconRefDefnHash (_g: TcGlobals) (eref1:EntityRef) =
     hash eref1.LogicalName 
 
 let tyconRefDefnEq g (eref1:EntityRef) (eref2: EntityRef) =
-    tyconRefEq g eref1 eref2 
+    tyconRefEq g eref1 eref2 || 
+
     // Signature items considered equal to implementation items
-    || ((eref1.DefinitionRange = eref2.DefinitionRange || eref1.SigRange = eref2.SigRange) &&
-        (eref1.LogicalName = eref2.LogicalName))
+    eref1.DefinitionRange <> Range.rangeStartup && eref1.DefinitionRange <> Range.range0 && eref1.DefinitionRange <> Range.rangeCmdArgs &&
+    (eref1.DefinitionRange = eref2.DefinitionRange || eref1.SigRange = eref2.SigRange) &&
+    eref1.LogicalName = eref2.LogicalName
 
-let valRefDefnHash (_g: TcGlobals) (vref1:ValRef)=
+let valRefDefnHash (_g: TcGlobals) (vref1:ValRef) =
     hash vref1.DisplayName
 
 let valRefDefnEq g (vref1:ValRef) (vref2: ValRef) =
-    valRefEq g vref1 vref2 
+    valRefEq g vref1 vref2 ||
+
     // Signature items considered equal to implementation items
-    || ((vref1.DefinitionRange = vref2.DefinitionRange || vref1.SigRange = vref2.SigRange)) && 
-        (vref1.LogicalName = vref2.LogicalName)
+    vref1.DefinitionRange <> Range.rangeStartup && vref1.DefinitionRange <> Range.range0 && vref1.DefinitionRange <> Range.rangeCmdArgs &&
+    (vref1.DefinitionRange = vref2.DefinitionRange || vref1.SigRange = vref2.SigRange) && 
+    vref1.LogicalName = vref2.LogicalName
 
 let unionCaseRefDefnEq g (uc1:UnionCaseRef) (uc2: UnionCaseRef) =
     uc1.CaseName = uc2.CaseName && tyconRefDefnEq g uc1.TyconRef uc2.TyconRef

tests/service/CSharpProjectAnalysis.fs

@@ -146,3 +146,53 @@ let _ = CSharpClass(0)
         Seq.exists (fun (mfv : FSharpMemberOrFunctionOrValue) -> mfv.IsEffectivelySameAs ctor) members |> should be True
     | None -> failwith "Expected Some for DeclaringEntity"
 
+let getEntitiesUses source =
+    let csharpAssembly = PathRelativeToTestAssembly "CSharp_Analysis.dll"
+    let results, _ = getProjectReferences(source, [csharpAssembly], None, None)
+    results.GetAllUsesOfAllSymbols()
+    |> Async.RunSynchronously
+    |> Seq.choose (fun su ->
+        match su.Symbol with
+        | :? FSharpEntity as entity -> Some entity
+        | _ -> None)
+    |> List.ofSeq
+
+[<Test>]
+#if NETCOREAPP2_0
+[<Ignore("SKIPPED: need to check if these tests can be enabled for .NET Core testing of FSharp.Compiler.Service")>]
+#endif
+let ``Different types with the same short name equality check`` () =
+    let source = """
+module CtorTest
+
+let (s1: System.String) = null
+let (s2: FSharp.Compiler.Service.Tests.String) = null
+"""
+
+    let stringSymbols =
+        getEntitiesUses source
+        |> List.filter (fun entity -> entity.LogicalName = "String")
+
+    match stringSymbols with
+    | e1 :: e2 :: [] -> e1.IsEffectivelySameAs(e2) |> should be False
+    | _ -> sprintf "Expecting two symbols, got %A" stringSymbols |> failwith
+
+[<Test>]
+#if NETCOREAPP2_0
+[<Ignore("SKIPPED: need to check if these tests can be enabled for .NET Core testing of FSharp.Compiler.Service")>]
+#endif
+let ``Different namespaces with the same short name equality check`` () =
+    let source = """
+module CtorTest
+
+open System.Linq
+open FSharp.Compiler.Service.Tests.Linq
+"""
+
+    let stringSymbols =
+        getEntitiesUses source
+        |> List.filter (fun entity -> entity.LogicalName = "Linq")
+
+    match stringSymbols with
+    | e1 :: e2 :: [] -> e1.IsEffectivelySameAs(e2) |> should be False
+    | _ -> sprintf "Expecting two symbols, got %A" stringSymbols |> failwith

tests/service/data/CSharp_Analysis/CSharpClass.cs

@@ -126,4 +126,14 @@ public static int StaticMember()
         }
     }
 
+    public class String
+    {
+    }
+
+    namespace Linq
+    {
+        public class DummyClass
+        {
+        }
+    }
 }