add comments about 139

Author: dsyme

tests/service/EditorTests.fs

@@ -35,7 +35,7 @@ let ``Intro test`` () =
     let inputLines = input.Split('\n')
     let file = "/home/user/Test.fsx"
     let untyped, typeCheckResults =  parseAndTypeCheckFileInProject(file, input) 
-    let identToken = Parser.tagOfToken(Parser.token.IDENT("")) 
+    let identToken = FSharpTokenTag.IDENT
 
     // We only expect one reported error. However,
     // on Unix, using filenames like /home/user/Test.fsx gives a second copy of all parse errors due to the
@@ -216,7 +216,7 @@ let ``Expression typing test`` () =
     let inputLines = input3.Split('\n')
     let file = "/home/user/Test.fsx"
     let untyped, typeCheckResults =  parseAndTypeCheckFileInProject(file, input3) 
-    let identToken = Parser.tagOfToken(Parser.token.IDENT("")) 
+    let identToken = FSharpTokenTag.IDENT
 
     // We only expect one reported error. However,
     // on Unix, using filenames like /home/user/Test.fsx gives a second copy of all parse errors due to the
@@ -239,6 +239,10 @@ let ``Expression typing test`` () =
                "StartsWith"; "Substring"; "ToCharArray"; "ToLower"; "ToLowerInvariant";
                "ToString"; "ToUpper"; "ToUpperInvariant"; "Trim"; "TrimEnd"; "TrimStart"])
 
+// The underlying problem is that the parser error recovery doesn't include _any_ information for
+// the incomplete member:
+//    member x.Test = 
+
 [<Test; Ignore("Currently failing, see #139")>]
 let ``Find function from member 1`` () = 
     let input = 

tests/service/FsiTests.fs

@@ -142,7 +142,7 @@ let ``ParseAndCheckInteraction test 1``() =
 
     // Check we can't get a declaration location for text in the F# interactive state (because the file doesn't exist)
     // TODO: check that if we use # line directives, then the file will exist correctly
-    let identToken = Parser.tagOfToken(Parser.token.IDENT("")) 
+    let identToken = FSharpTokenTag.IDENT
     typedResults.GetDeclarationLocationAlternate(1,6,"xxxxxx",["xxxxxx"]) |> Async.RunSynchronously |> shouldEqual (FSharpFindDeclResult.DeclNotFound  FSharpFindDeclFailureReason.NoSourceCode) 
 
     // Check we can get a tooltip for text in the F# interactive state